You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/11 11:42:47 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #12311: [Improvement][Test] Block the usage of powermock and move mockito dependencies from sub-modules to root pom

kezhenxu94 commented on PR #12311:
URL: https://github.com/apache/dolphinscheduler/pull/12311#issuecomment-1274551257

   > I'm thinking about changing the `apply` in pre-commit hook to `check`. The reason is if I add a `regex step` to block `import org.powermock.*`, contributors may get quite confused when pre-commit hook automatically deletes the import, just the same as the `wildcard imports` we discussed before: [#11458 (comment)](https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945087368)
   > 
   > WDYT @kezhenxu94 @zhongjiajie
   
   Sounds good to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org