You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/05/23 22:36:48 UTC
Review Request 47744: deliver event synchronously if it is rejected
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47744/
-----------------------------------------------------------
Review request for geode, Scott Jewell and Ken Howe.
Bugs: GEODE-1428
https://issues.apache.org/jira/browse/GEODE-1428
Repository: geode
Description
-------
If the event is rejected by the async thread pool then process it synchronously instead of logging a warning.
Changed unit test to use close instead of emergencyClose.
Doing this caused an event to be sent after the async thread
pool was shutdown which resulted in a suspect warning without
this fix.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java d28496cc6e58cf061ce996d45526f3a0bd3ab10f
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GemFireCacheImplTest.java 7f95cadd68ad218f32129f6369198ae4ed968454
Diff: https://reviews.apache.org/r/47744/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 47744: deliver event synchronously if it is
rejected
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47744/#review134645
-----------------------------------------------------------
Ship it!
Neglected to click Ship It! when I revoewed this last evening.
- Ken Howe
On May 23, 2016, 10:36 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47744/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 10:36 p.m.)
>
>
> Review request for geode, Scott Jewell and Ken Howe.
>
>
> Bugs: GEODE-1428
> https://issues.apache.org/jira/browse/GEODE-1428
>
>
> Repository: geode
>
>
> Description
> -------
>
> If the event is rejected by the async thread pool then process it synchronously instead of logging a warning.
>
> Changed unit test to use close instead of emergencyClose.
> Doing this caused an event to be sent after the async thread
> pool was shutdown which resulted in a suspect warning without
> this fix.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java d28496cc6e58cf061ce996d45526f3a0bd3ab10f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GemFireCacheImplTest.java 7f95cadd68ad218f32129f6369198ae4ed968454
>
> Diff: https://reviews.apache.org/r/47744/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 47744: deliver event synchronously if it is
rejected
Posted by Scott Jewell <sj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47744/#review134640
-----------------------------------------------------------
Ship it!
Ship It!
- Scott Jewell
On May 23, 2016, 10:36 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47744/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 10:36 p.m.)
>
>
> Review request for geode, Scott Jewell and Ken Howe.
>
>
> Bugs: GEODE-1428
> https://issues.apache.org/jira/browse/GEODE-1428
>
>
> Repository: geode
>
>
> Description
> -------
>
> If the event is rejected by the async thread pool then process it synchronously instead of logging a warning.
>
> Changed unit test to use close instead of emergencyClose.
> Doing this caused an event to be sent after the async thread
> pool was shutdown which resulted in a suspect warning without
> this fix.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java d28496cc6e58cf061ce996d45526f3a0bd3ab10f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GemFireCacheImplTest.java 7f95cadd68ad218f32129f6369198ae4ed968454
>
> Diff: https://reviews.apache.org/r/47744/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>