You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by discipleforteen <gi...@git.apache.org> on 2017/01/19 01:32:10 UTC
[GitHub] spark pull request #16637: [SPARK-19225][SQL]round decimal return normal val...
GitHub user discipleforteen opened a pull request:
https://github.com/apache/spark/pull/16637
[SPARK-19225][SQL]round decimal return normal value but not null
## What changes were proposed in this pull request?
in https://issues.apache.org/jira/browse/SPARK-19225,
change the round decimal function. select round(4.4, 2) can return 4.4 , not return null when round scale is larger than decimal scale
## How was this patch tested?
Jeckins
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/discipleforteen/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16637
----
commit 800db2d592e85fb3b7ba7c1994314fac0e5de206
Author: discipleforteen <32...@qq.com>
Date: 2017-01-19T01:24:59Z
cut round (decimal, scale)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16637
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...
Posted by discipleforteen <gi...@git.apache.org>.
Github user discipleforteen commented on the issue:
https://github.com/apache/spark/pull/16637
how about cast constant 4.4 to double instead of decimal like spark 1.x. @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16637: [SPARK-19225][SQL]round decimal return normal val...
Posted by discipleforteen <gi...@git.apache.org>.
Github user discipleforteen closed the pull request at:
https://github.com/apache/spark/pull/16637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16637
Can you add a test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16637
Also I think we need to update the code gen path as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...
Posted by discipleforteen <gi...@git.apache.org>.
Github user discipleforteen commented on the issue:
https://github.com/apache/spark/pull/16637
ok. i will try to update code gen and MathFunctionsSuite.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...
Posted by discipleforteen <gi...@git.apache.org>.
Github user discipleforteen commented on the issue:
https://github.com/apache/spark/pull/16637
@AmplabJenkins @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org