You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Zhou <ja...@gmail.com> on 2024/05/15 12:45:24 UTC
Review Request 74991: populate unevictable field from memory.stat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74991/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Populate unevictable field from memory.stat
Diffs
-----
src/linux/cgroups2.hpp ecac09d9b3efb1f6fdb172b93e7e462dcbfde60c
src/linux/cgroups2.cpp 2057b329297c9c29a14d972e0068c21c41366b09
Diff: https://reviews.apache.org/r/74991/diff/1/
Testing
-------
Field is confirmed to exist by checking memory.stat file on a cgroups2-enabled machine.
Thanks,
Jason Zhou
Re: Review Request 74991: [cgroups2] populate unevictable field from memory.stat
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74991/#review226455
-----------------------------------------------------------
Ship it!
Ship It!
src/linux/cgroups2.hpp
Lines 301 (patched)
<https://reviews.apache.org/r/74991/#comment314662>
nit: end with period
- Benjamin Mahler
On May 15, 2024, 1:07 p.m., Jason Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74991/
> -----------------------------------------------------------
>
> (Updated May 15, 2024, 1:07 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> populate unevictable field from memory.stat
>
>
> Diffs
> -----
>
> src/linux/cgroups2.hpp ecac09d9b3efb1f6fdb172b93e7e462dcbfde60c
> src/linux/cgroups2.cpp 2057b329297c9c29a14d972e0068c21c41366b09
>
>
> Diff: https://reviews.apache.org/r/74991/diff/2/
>
>
> Testing
> -------
>
> Field is confirmed to exist by checking memory.stat file on a cgroups2-enabled machine.
>
>
> Thanks,
>
> Jason Zhou
>
>
Re: Review Request 74991: [cgroups2] populate unevictable field from memory.stat
Posted by Jason Zhou <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74991/
-----------------------------------------------------------
(Updated May 15, 2024, 1:07 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
[cgroups2] populate unevictable field from memory.stat
Repository: mesos
Description
-------
populate unevictable field from memory.stat
Diffs
-----
src/linux/cgroups2.hpp ecac09d9b3efb1f6fdb172b93e7e462dcbfde60c
src/linux/cgroups2.cpp 2057b329297c9c29a14d972e0068c21c41366b09
Diff: https://reviews.apache.org/r/74991/diff/2/
Testing
-------
Field is confirmed to exist by checking memory.stat file on a cgroups2-enabled machine.
Thanks,
Jason Zhou
Re: Review Request 74991: [cgroup2] populate unevictable field from memory.stat
Posted by Jason Zhou <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74991/
-----------------------------------------------------------
(Updated May 15, 2024, 12:47 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
[cgroup2] populate unevictable field from memory.stat
Repository: mesos
Description
-------
Populate unevictable field from memory.stat
Diffs
-----
src/linux/cgroups2.hpp ecac09d9b3efb1f6fdb172b93e7e462dcbfde60c
src/linux/cgroups2.cpp 2057b329297c9c29a14d972e0068c21c41366b09
Diff: https://reviews.apache.org/r/74991/diff/1/
Testing
-------
Field is confirmed to exist by checking memory.stat file on a cgroups2-enabled machine.
Thanks,
Jason Zhou