You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2023/05/24 08:54:13 UTC
[GitHub] [maven-parent] gnodet opened a new pull request, #122: Bump sisu to 0.9.0.M2
gnodet opened a new pull request, #122:
URL: https://github.com/apache/maven-parent/pull/122
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] gnodet commented on pull request #122: [MPOM-421] Bump sisu from 0.3.5 to 0.9.0.M2
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #122:
URL: https://github.com/apache/maven-parent/pull/122#issuecomment-1571716899
> While I'm ok to use the newer Sisu plugin, I'm not sure about the impact of updating Sisu as dependency.
Agreed, though maven 3.9.x and master have recently upgraded to that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] gnodet merged pull request #122: [MPOM-421] Bump sisu from 0.3.5 to 0.9.0.M2
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #122:
URL: https://github.com/apache/maven-parent/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slachiewicz commented on pull request #122: Bump sisu from 0.3.5 to 0.9.0.M2
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #122:
URL: https://github.com/apache/maven-parent/pull/122#issuecomment-1570266079
While I'm ok to use the newer Sisu plugin, I'm not sure about the impact of updating Sisu as dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slachiewicz commented on pull request #122: [MPOM-421] Bump sisu from 0.3.5 to 0.9.0.M2
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #122:
URL: https://github.com/apache/maven-parent/pull/122#issuecomment-1571812032
> > While I'm ok to use the newer Sisu plugin, I'm not sure about the impact of updating Sisu as dependency.
>
> Agreed, though maven 3.9.x and master have recently upgraded to that one.
That means if the min API level for the plugin will be updated to 3.9.3(?) This new impl will be injected by Maven. In any earlier Maven - plugin will get the old version. Right?
We are not using too much of Sisu internals yet. In the release note I saw enhancement to define configuration. Soon we may get Path support as Parameter type in Sisu, this may lead to some confusion, hope our CI could catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] gnodet commented on pull request #122: [MPOM-421] Bump sisu from 0.3.5 to 0.9.0.M2
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #122:
URL: https://github.com/apache/maven-parent/pull/122#issuecomment-1573724662
> > > While I'm ok to use the newer Sisu plugin, I'm not sure about the impact of updating Sisu as dependency.
> >
> >
> > Agreed, though maven 3.9.x and master have recently upgraded to that one.
>
> That means if the min API level for the plugin will be updated to 3.9.3(?) This new impl will be injected by Maven. In any earlier Maven - plugin will get the old version. Right? We are not using too much of Sisu internals yet. In the release note I saw enhancement to define configuration. Soon we may get Path support as Parameter type in Sisu, this may lead to some confusion, hope our CI could catch it.
Maven actually controls which version of sisu.plexus is used, so I doubt the upgrade will have any effect for plugins or other components since whatever they depend on will be overridden by the version provided by maven. My goal was really to target the plugin or APT processor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org