You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/06 02:36:26 UTC

[GitHub] [flink] liuyongvs commented on a change in pull request #12790: Es hotfix

liuyongvs commented on a change in pull request #12790:
URL: https://github.com/apache/flink/pull/12790#discussion_r449956717



##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSinkFactory.java
##########
@@ -113,7 +113,7 @@ private void validate(Elasticsearch6Configuration config, Configuration original
 		validate(
 			maxActions == -1 || maxActions >= 1,
 			() -> String.format(
-				"'%s' must be at least 1 character. Got: %s",
+				"'%s' must be at least 1. Got: %s",

Review comment:
       @wuchong @dawidwys ,it is a typo indeed. Because sink.bulk-flush.max-actions config is int type. And you can compare with other in this class




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org