[GitHub] [superset] rusackas commented on a diff in pull request #22772: chore: Localization of several charts and elements pt. 2

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #22772:
URL: https://github.com/apache/superset/pull/22772#discussion_r1086893480


##########
superset-frontend/plugins/legacy-plugin-chart-calendar/src/Calendar.js:
##########
@@ -88,7 +88,8 @@ function Calendar(element, props) {
   Object.keys(metricsData).forEach(metric => {
     const calContainer = div.append('div');
     if (showMetricName) {
-      calContainer.text(`Metric: ${verboseMap[metric] || metric}`);
+      // eslint-disable-next-line prefer-template
+      calContainer.text(t('Metric') + `: ${verboseMap[metric] || metric}`);

Review Comment:
   Would this work as 
   ```suggestion
         calContainer.text(`${t('Metric')}: ${verboseMap[metric] || metric}`);
   ```
   to get rid of the lint disabling?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org