You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Ahmed Radwan (JIRA)" <ji...@apache.org> on 2011/06/17 04:14:49 UTC
[jira] [Created] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
------------------------------------------------------------------------------
Key: MAPREDUCE-2602
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
Project: Hadoop Map/Reduce
Issue Type: Improvement
Reporter: Ahmed Radwan
Assignee: Ahmed Radwan
Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061073#comment-13061073 ]
Hadoop QA commented on MAPREDUCE-2602:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12485529/MAPREDUCE-2602_rev2.patch
against trunk revision 1143252.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.fs.TestFileSystem
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/439//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/439//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/439//console
This message is automatically generated.
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch, MAPREDUCE-2602_rev2.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070379#comment-13070379 ]
Harsh J commented on MAPREDUCE-2602:
------------------------------------
+1 from me too, that change covered my comment! :)
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch, MAPREDUCE-2602_rev2.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052974#comment-13052974 ]
Tom White commented on MAPREDUCE-2602:
--------------------------------------
+1
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071082#comment-13071082 ]
Hudson commented on MAPREDUCE-2602:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #749 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/749/])
MAPREDUCE-2602. Allow setting of end-of-record delimiter for TextInputFormat for the old API. Contributed by Ahmed Radwan.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150926
Files :
* /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/TextInputFormat.java
* /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/LineRecordReader.java
* /hadoop/common/trunk/mapreduce/CHANGES.txt
* /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestLineRecordReader.java
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2602.patch, MAPREDUCE-2602_rev2.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070828#comment-13070828 ]
Hudson commented on MAPREDUCE-2602:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #756 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/756/])
MAPREDUCE-2602. Allow setting of end-of-record delimiter for TextInputFormat for the old API. Contributed by Ahmed Radwan.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150926
Files :
* /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/TextInputFormat.java
* /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapred/LineRecordReader.java
* /hadoop/common/trunk/mapreduce/CHANGES.txt
* /hadoop/common/trunk/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestLineRecordReader.java
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2602.patch, MAPREDUCE-2602_rev2.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064833#comment-13064833 ]
Tom White commented on MAPREDUCE-2602:
--------------------------------------
+1 to the new patch.
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch, MAPREDUCE-2602_rev2.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053561#comment-13053561 ]
Ahmed Radwan commented on MAPREDUCE-2602:
-----------------------------------------
The Hadoop-QA test failures above are not related to the submitted patch.
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2602:
------------------------------------
Status: Open (was: Patch Available)
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2602:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk based on +1s above. Thanks, Ahmed!
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2602.patch, MAPREDUCE-2602_rev2.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2602:
------------------------------------
Status: Patch Available (was: Open)
This patch is backward compatible.
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2602:
------------------------------------
Status: Patch Available (was: Open)
This batch is backward compatible.
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2602:
------------------------------------
Attachment: MAPREDUCE-2602_rev2.patch
Many thanks Harsh :)
I have updated the patch to keep old constructors unchanged, so it'll remain compatible.
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch, MAPREDUCE-2602_rev2.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2602:
------------------------------------
Attachment: MAPREDUCE-2602.patch
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055125#comment-13055125 ]
Harsh J commented on MAPREDUCE-2602:
------------------------------------
The changes include constructor changes to LineReader class. Is that OK to go in without an Incompat mark? Its an internal class, but its been public so far.
Rest of the changes appear all good :)
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2602) Allow setting of end-of-record
delimiter for TextInputFormat (for the old API)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050901#comment-13050901 ]
Hadoop QA commented on MAPREDUCE-2602:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482890/MAPREDUCE-2602.patch
against trunk revision 1136261.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.fs.TestFileSystem
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/402//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/402//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/402//console
This message is automatically generated.
> Allow setting of end-of-record delimiter for TextInputFormat (for the old API)
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2602
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2602
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-2602.patch
>
>
> Since there are users who are still using the old MR API, it will be useful to modify the org.apache.hadoop.mapred.LineRecordReader and org.apache.hadoop.mapred.TextInputFormat to be able to use custom (user-specified) end-of-record delimiters. This will make use of the LineReader improvement introduced in HADOOP-7096 that enables the LineReader to break lines at user-specified delimiters.
> Note: MAPREDUCE-2254 already added this improvement to the new API (but not the old API).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira