You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/03/05 10:25:01 UTC
[GitHub] zeppelin pull request #2097: [MINOR][ZEPPELIN-2154] Enable work in the web d...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/2097
[MINOR][ZEPPELIN-2154] Enable work in the web dev mode if changing default server port
### What is this PR for?
If user change `zeppelin.server.port` variable in zeppelin-site.xml, zeppelin doesn't work in web development.
In order for user to run zeppelin correctly, so that user can add `SERVER_PORT` as an environment variable when running web application development mode.
### What type of PR is it?
[Bug Fix | Improvement | Documentation]
### What is the Jira issue?
* [ZEPPELIN-2154](https://issues.apache.org/jira/browse/ZEPPELIN-2154)
### How should this be tested?
1. Change `zeppelin.server.port` from 8080 to 8888 (or another port) in `zeppelin-site.xml`
2. Run zeppelin (`bin/zeppelin-daemon.sh start`)
3. Run web development mode under `zeppelin-web` folder such like `SERVER_PORT=8888 yarn run dev`
4. Connect `localhost:9000`
### Screenshots (if appropriate)
[Before]
[After]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, added in README.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2154_port_webDevMode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2097
----
commit ce9c18e3bef120f99edd32a6fa8ac185cac1ebb9
Author: soralee <so...@zepl.com>
Date: 2017-03-05T09:08:30Z
enable custom server port in web dev mode
commit 54f0a96d92f26236841ed0e5c9647abc54c8089d
Author: soralee <so...@zepl.com>
Date: 2017-03-05T10:11:12Z
add README.md
commit 49128a832ac6e4b78c163b2977d6fa5624e9fce5
Author: soralee <so...@zepl.com>
Date: 2017-03-05T10:21:03Z
add README.md
commit 6f2b8e4e99575d041fba0803f0e95a18d8e921d9
Author: soralee <so...@zepl.com>
Date: 2017-03-05T10:23:29Z
modify typo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2097: [MINOR][ZEPPELIN-2154] Enable work in the web dev mode...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2097
@AhyoungRyu Sure, Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2097: [MINOR][ZEPPELIN-2154] Enable work in the web dev mode...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2097
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2097: [MINOR][ZEPPELIN-2154] Enable work in the web d...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/2097
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2097: [MINOR][ZEPPELIN-2154] Enable work in the web dev mode...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2097
Tested and works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2097: [MINOR][ZEPPELIN-2154] Enable work in the web d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2097
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2097: [MINOR][ZEPPELIN-2154] Enable work in the web dev mode...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2097
@soralee I just merged this into master but automatically couldn't into `branch-0.7`. Can you create a separate PR for `branch-0.7`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2097: [MINOR][ZEPPELIN-2154] Enable work in the web dev mode...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2097
@soralee Thanks for the improvement. Also tested and it works well. Maybe [this part](https://zeppelin.apache.org/contribution/webapplication.html#dev-mode) needs to be updated accordingly after this PR merged :)
Will merge into master and branch-0.7 if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2097: [MINOR][ZEPPELIN-2154] Enable work in the web d...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/2097
[MINOR][ZEPPELIN-2154] Enable work in the web dev mode if changing default server port
### What is this PR for?
If user change `zeppelin.server.port` variable in zeppelin-site.xml, zeppelin doesn't work in web development.
In order for user to run zeppelin correctly, so that user can add `SERVER_PORT` as an environment variable when running web application development mode.
### What type of PR is it?
[Bug Fix | Improvement | Documentation]
### What is the Jira issue?
* [ZEPPELIN-2154](https://issues.apache.org/jira/browse/ZEPPELIN-2154)
### How should this be tested?
1. Change `zeppelin.server.port` from 8080 to 8888 (or another port) in `zeppelin-site.xml`
2. Run zeppelin (`bin/zeppelin-daemon.sh start`)
3. Run web development mode under `zeppelin-web` folder such like `SERVER_PORT=8888 yarn run dev`
4. Connect `localhost:9000`
### Screenshots (if appropriate)
[Before]
[After]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, added in README.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2154_port_webDevMode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2097
----
commit bf22961661e4c90313772f33ca895a96231df0c3
Author: soralee <so...@zepl.com>
Date: 2017-03-05T09:08:30Z
enable custom server port in web dev mode
commit 394d3bb203f5c51aa2bdcf30c4e54429725a4ec4
Author: soralee <so...@zepl.com>
Date: 2017-03-05T10:11:12Z
add README.md
commit 6b26cba583eac63afe7f0c7900ca5d541834ee0e
Author: soralee <so...@zepl.com>
Date: 2017-03-05T10:21:03Z
add README.md
commit e6d1801edfbf9d149b40e0555b5c31b367f59b01
Author: soralee <so...@zepl.com>
Date: 2017-03-05T10:23:29Z
modify typo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2097: [MINOR][ZEPPELIN-2154] Enable work in the web dev mode...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2097
@khalidhuseynov @AhyoungRyu Thanks for review!
And let me update [the document](https://zeppelin.apache.org/contribution/webapplication.html#dev-mode) after being merged this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2097: [MINOR][ZEPPELIN-2154] Enable work in the web dev mode...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2097
Thanks for review @1ambda :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---