You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "srijeet0406 (via GitHub)" <gi...@apache.org> on 2023/02/17 05:09:41 UTC
[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7356: Added missing permissions for routes
srijeet0406 opened a new pull request, #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR is not related to any issue. It adds the missing required permissions for some of the routes.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Make sure the routes can still be accessed by the appropriate users.
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
- master
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7356: Added missing permissions for routes
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356#issuecomment-1434111631
# [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7356](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (79cf247) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/5335f8098c27d07be4aba924b7e4503c258f3e2a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5335f80) will **increase** coverage by `5.77%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #7356 +/- ##
============================================
+ Coverage 25.06% 30.84% +5.77%
Complexity 98 98
============================================
Files 593 405 -188
Lines 73646 35443 -38203
Branches 90 90
============================================
- Hits 18460 10931 -7529
+ Misses 53435 23436 -29999
+ Partials 1751 1076 -675
```
| Flag | Coverage Δ | |
|---|---|---|
| golib_unit | `53.14% <ø> (-0.02%)` | :arrow_down: |
| grove_unit | `4.60% <ø> (ø)` | |
| t3c_unit | `5.33% <ø> (ø)` | |
| traffic_monitor_unit | `20.43% <ø> (ø)` | |
| traffic_ops_unit | `?` | |
| traffic_stats_unit | `10.41% <ø> (ø)` | |
| unit_tests | `26.11% <ø> (+3.51%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/go-atscfg/serverunknown.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLWF0c2NmZy9zZXJ2ZXJ1bmtub3duLmdv) | `77.96% <0.00%> (-1.70%)` | :arrow_down: |
| [lib/go-atscfg/parentabstraction.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLWF0c2NmZy9wYXJlbnRhYnN0cmFjdGlvbi5nbw==) | `79.47% <0.00%> (-0.53%)` | :arrow_down: |
| [traffic\_ops/traffic\_ops\_golang/routing/routes.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3JvdXRpbmcvcm91dGVzLmdv) | | |
| [...g/deliveryservice/consistenthash/consistenthash.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2RlbGl2ZXJ5c2VydmljZS9jb25zaXN0ZW50aGFzaC9jb25zaXN0ZW50aGFzaC5nbw==) | | |
| [...olang/deliveryservice/letsencrypt\_dns\_challenge.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2RlbGl2ZXJ5c2VydmljZS9sZXRzZW5jcnlwdF9kbnNfY2hhbGxlbmdlLmdv) | | |
| [traffic\_ops/traffic\_ops\_golang/tocookie/cookie.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3RvY29va2llL2Nvb2tpZS5nbw==) | | |
| [...affic\_ops/traffic\_ops\_golang/crstats/cdnrouting.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2Nyc3RhdHMvY2Rucm91dGluZy5nbw==) | | |
| [traffic\_ops/traffic\_ops\_golang/server/servers.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3NlcnZlci9zZXJ2ZXJzLmdv) | | |
| [...raffic\_ops/traffic\_ops\_golang/cdn\_lock/cdn\_lock.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2Nkbl9sb2NrL2Nkbl9sb2NrLmdv) | | |
| [...lang/profileparameter/postprofileparametersbyid.go](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3Byb2ZpbGVwYXJhbWV0ZXIvcG9zdHByb2ZpbGVwYXJhbWV0ZXJzYnlpZC5nbw==) | | |
| ... and [180 more](https://codecov.io/gh/apache/trafficcontrol/pull/7356?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7356: Added missing permissions for routes
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on code in PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356#discussion_r1110187183
##########
docs/source/api/v4/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-deliveryservices-xmlid-xmlid-sslkeys-renew:
Review Comment:
this is a duplicate label. The unversioned links are always used in the latest version, so that you don't need to hunt them down throughout the rest of the docs every time we make a new API version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7356: Added missing permissions for routes
Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 commented on code in PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356#discussion_r1114784544
##########
docs/source/api/v4/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -25,7 +25,7 @@ Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to ren
:Auth. Required: Yes
:Roles Required: "admin"
-:Permissions Required: ACME:READ, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
Review Comment:
Same key repeated twice: `DS-SECURITY-KEY:CREATE`
##########
docs/source/api/v5/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -25,7 +25,7 @@ Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to ren
:Auth. Required: Yes
:Roles Required: "admin"
-:Permissions Required: ACME:READ, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
Review Comment:
Same key repeated twice: `DS-SECURITY-KEY:CREATE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7356: Added missing permissions for routes
Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 commented on code in PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356#discussion_r1112204560
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -157,7 +157,7 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodDelete, Path: `acme_accounts/{provider}/{email}?$`, Handler: acme.Delete, RequiredPrivLevel: auth.PrivLevelAdmin, RequiredPermissions: []string{"ACME:DELETE", "ACME:READ"}, Authenticated: Authenticated, Middlewares: nil, ID: 40343905641},
//Delivery service ACME
- {Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: nil, Authenticated: Authenticated, Middlewares: nil, ID: 25343905731},
+ {Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: []string{"ACME:READ", "DS-SECURITY-KEY:UPDATE", "DS-SECURITY-KEY:READ", "DELIVERY-SERVICE:READ", "DELIVERY-SERVICE:UPDATE"}, Authenticated: Authenticated, Middlewares: nil, ID: 25343905731},
Review Comment:
Do we need "DS-SECURITY-KEY:CREATE"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7356: Added missing permissions for routes
Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 commented on code in PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356#discussion_r1112204560
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -157,7 +157,7 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodDelete, Path: `acme_accounts/{provider}/{email}?$`, Handler: acme.Delete, RequiredPrivLevel: auth.PrivLevelAdmin, RequiredPermissions: []string{"ACME:DELETE", "ACME:READ"}, Authenticated: Authenticated, Middlewares: nil, ID: 40343905641},
//Delivery service ACME
- {Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: nil, Authenticated: Authenticated, Middlewares: nil, ID: 25343905731},
+ {Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: []string{"ACME:READ", "DS-SECURITY-KEY:UPDATE", "DS-SECURITY-KEY:READ", "DELIVERY-SERVICE:READ", "DELIVERY-SERVICE:UPDATE"}, Authenticated: Authenticated, Middlewares: nil, ID: 25343905731},
Review Comment:
Do we need `DS-SECURITY-KEY:CREATE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7356: Added missing permissions for routes
Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 commented on code in PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356#discussion_r1112199512
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -157,7 +157,7 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodDelete, Path: `acme_accounts/{provider}/{email}?$`, Handler: acme.Delete, RequiredPrivLevel: auth.PrivLevelAdmin, RequiredPermissions: []string{"ACME:DELETE", "ACME:READ"}, Authenticated: Authenticated, Middlewares: nil, ID: 40343905641},
//Delivery service ACME
- {Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: nil, Authenticated: Authenticated, Middlewares: nil, ID: 25343905731},
+ {Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: []string{"ACME:READ", "DS-SECURITY-KEY:UPDATE", "DS-SECURITY-KEY:READ", "DELIVERY-SERVICE:READ", "DELIVERY-SERVICE:UPDATE"}, Authenticated: Authenticated, Middlewares: nil, ID: 25343905731},
Review Comment:
Do we need `"DS-SECURITY-KEY:CREATE"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7356: Added missing permissions for routes
Posted by "kdamichie (via GitHub)" <gi...@apache.org>.
kdamichie commented on code in PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356#discussion_r1119331857
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -561,7 +561,7 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodDelete, Path: `acme_accounts/{provider}/{email}?$`, Handler: acme.Delete, RequiredPrivLevel: auth.PrivLevelAdmin, RequiredPermissions: []string{"ACME:DELETE", "ACME:READ"}, Authenticated: Authenticated, Middlewares: nil, ID: 4034390564},
//Delivery service ACME
- {Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: nil, Authenticated: Authenticated, Middlewares: nil, ID: 2534390573},
+ {Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: []string{"ACME:READ", "DS-SECURITY-KEY:DELETE", "DS-SECURITY-KEY:CREATE", "DS-SECURITY-KEY:UPDATE", "DS-SECURITY-KEY:READ", "DELIVERY-SERVICE:READ", "DELIVERY-SERVICE:UPDATE", "DS-SECURITY-KEY:CREATE"}, Authenticated: Authenticated, Middlewares: nil, ID: 2534390573},
Review Comment:
Duplicate key DS-SECURITY-KEY:CREATE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7356: Added missing permissions for routes
Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 commented on code in PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356#discussion_r1112199512
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -157,7 +157,7 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodDelete, Path: `acme_accounts/{provider}/{email}?$`, Handler: acme.Delete, RequiredPrivLevel: auth.PrivLevelAdmin, RequiredPermissions: []string{"ACME:DELETE", "ACME:READ"}, Authenticated: Authenticated, Middlewares: nil, ID: 40343905641},
//Delivery service ACME
- {Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: nil, Authenticated: Authenticated, Middlewares: nil, ID: 25343905731},
+ {Version: api.Version{Major: 5, Minor: 0}, Method: http.MethodPost, Path: `deliveryservices/xmlId/{xmlid}/sslkeys/renew$`, Handler: deliveryservice.RenewAcmeCertificate, RequiredPrivLevel: auth.PrivLevelOperations, RequiredPermissions: []string{"ACME:READ", "DS-SECURITY-KEY:UPDATE", "DS-SECURITY-KEY:READ", "DELIVERY-SERVICE:READ", "DELIVERY-SERVICE:UPDATE"}, Authenticated: Authenticated, Middlewares: nil, ID: 25343905731},
Review Comment:
Do we need `"DS-SECURITY-KEY:CREATE"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 merged pull request #7356: Added missing permissions for routes
Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 merged PR #7356:
URL: https://github.com/apache/trafficcontrol/pull/7356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org