You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "divijvaidya (via GitHub)" <gi...@apache.org> on 2023/08/01 16:21:27 UTC

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1280547981


##########
core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala:
##########
@@ -124,7 +124,7 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {
   @ValueSource(strings = Array("zk", "kraft"))
   def testSendWithInvalidCreateTime(quorum: String): Unit = {

Review Comment:
   let's retain the test with older/deprecated config and two new tests with max and min config here.



##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -642,7 +642,7 @@ class DynamicBrokerReconfigurationTest extends QuorumTestHarness with SaslSetup
     props.put(KafkaConfig.CompressionTypeProp, "gzip")
     props.put(KafkaConfig.LogPreAllocateProp, true.toString)
     props.put(KafkaConfig.LogMessageTimestampTypeProp, TimestampType.LOG_APPEND_TIME.toString)
-    props.put(KafkaConfig.LogMessageTimestampDifferenceMaxMsProp, "1000")

Review Comment:
   we need to retain all tests with older config so that we can catch regression in older config in 3.x series. Please add new tests for new configs everywhere



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org