This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git
commit c3006e987924c6efc23b781898b9c4940fe7932e
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Fri Sep 25 13:07:24 2026 +0200
chore(ads): drop the outdated flag-layout comments from AdsSymbolTableEntry
Refs #2773
---
.../ads/src/main/resources/protocols/ads/ads.mspec | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/protocols/ads/src/main/resources/protocols/ads/ads.mspec b/protocols/ads/src/main/resources/protocols/ads/ads.mspec
index 293a9b9563..3388d4a06c 100644
--- a/protocols/ads/src/main/resources/protocols/ads/ads.mspec
+++ b/protocols/ads/src/main/resources/protocols/ads/ads.mspec
@@ -887,10 +887,6 @@
[simple uint 32 offset ]
[simple uint 32 size ]
[simple uint 32 dataType ]
- // Start: Flags
- // https://github.com/jisotalo/ads-client/blob/master/src/ads-commons.ts#L619
- // Order of the bits if read Little-Endian and then accessing the bit flags
- // 7 6 5 4 3 2 1 0 | 15 14 13 12 11 10 9 8
[simple bit flagMethodDeref ]
[simple bit flagItfMethodAccess ]
[simple bit flagReadOnly ]
@@ -899,16 +895,11 @@
[simple bit flagReferenceTo ]
[simple bit flagBitValue ]
[simple bit flagPersistent ]
- // Bits 15..8 as defined in TcAdsDef.h (ADSSYMBOLFLAG_*): bits 11..8 are not flags but a
- // 4-bit task/context id (ADSSYMBOLFLAG_CONTEXTMASK 0x0F00).
[simple bit flagExtendedFlags ]
[simple bit flagInitOnReset ]
[simple bit flagStatic ]
[implicit bit flagAttributes 'attributes != null' ]
[simple uint 4 contextMask ]
- // https://github.com/jisotalo/ads-client/blob/master/src/ads-commons.ts#L679
- // Order of the bits if read Little-Endian and then accessing the bit flags
- // 7 6 5 4 3 2 1 0 | 15 14 13 12 11 10 9 8
[reserved uint 3 '0x0' ]
[simple bit flagVariantType ]
[simple bit flagOnlineChangePtrRefType ]
@@ -916,7 +907,6 @@
[simple bit flagRedundancyIgnore ]
[simple bit flagPlcPointerType ]
[reserved uint 8 '0x00' ]
- // End: Flags
[implicit uint 16 nameLength 'STR_LEN(name)' ]
[implicit uint 16 dataTypeNameLength 'STR_LEN(dataTypeName)' ]
[implicit uint 16 commentLength 'STR_LEN(comment)' ]
@@ -945,10 +935,6 @@
[simple uint 32 size ]
[simple uint 32 offset ]
[simple AdsDatatypeId dataType ]
- // Begin: Data Type Flags
- // Source (https://github.com/jisotalo/ads-client/blob/master/src/ads-commons.ts#L724)
- // 7 6 5 4 3 2 1 0 | 15 14 13 12 11 10 9 8 | 23 22 21 20 19 18 17 16 | 31 30 29 28 27 26 25 24
- // Byte 1
[implicit bit flagTypeGuid 'COUNT(guid) > 0' ]
[simple bit flagPropItem ]
[simple bit flagBitValues ]
@@ -957,7 +943,6 @@
[simple bit flagReferenceTo ]
[implicit bit flagDataType 'numChildren > 0' ]
[implicit bit flagDataItem 'numChildren == 0' ]
- // Byte 2
[reserved uint 2 '0x0' ]
[implicit bit flagExtendedInfos 'extendedInfos != null' ]
[implicit bit flagAttributes 'attributes != null' ]
@@ -965,7 +950,6 @@
[simple bit flagTComInterfacePtr ]
[simple bit flagCopyMask ]
[simple bit flagPersistent ]
- // Byte 3
[simple bit flagPlcPointerType ]
[simple bit flagInitOnReset ]
[simple bit flagPersistentDataType ]
@@ -974,7 +958,6 @@
[simple bit flagSoftwareProtectionLevels ]
[simple bit flagStatic ]
[simple bit flagAligned ]
- // Byte 4
[simple bit ExtendedFlags ]
[reserved uint 1 '0x0' ]
[simple bit flagExtendedEnumInfos ]