You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/03/17 18:29:42 UTC
[kudu-CR] Remove TRACE EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6415
to review the following change.
Change subject: Remove TRACE_EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
......................................................................
Remove TRACE_EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
This function gets called many thousands of times per maintenance
scheduler op. When enabling tracing, it fills up most of the trace
buffer very quickly, but is rarely interesting.
Change-Id: I2cbbe827c33a4110a7167d4121408f191b89082a
---
M src/kudu/tablet/diskrowset.cc
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/6415/1
--
To view, visit http://gerrit.cloudera.org:8080/6415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cbbe827c33a4110a7167d4121408f191b89082a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Remove TRACE EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Remove TRACE_EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbbe827c33a4110a7167d4121408f191b89082a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Remove TRACE EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Remove TRACE_EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
......................................................................
Remove TRACE_EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
This function gets called many thousands of times per maintenance
scheduler op. When enabling tracing, it fills up most of the trace
buffer very quickly, but is rarely interesting.
Change-Id: I2cbbe827c33a4110a7167d4121408f191b89082a
Reviewed-on: http://gerrit.cloudera.org:8080/6415
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
---
M src/kudu/tablet/diskrowset.cc
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cbbe827c33a4110a7167d4121408f191b89082a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Remove TRACE EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Remove TRACE_EVENT from EstimateBytesInPotentiallyAncientUndoDeltas
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbbe827c33a4110a7167d4121408f191b89082a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No