You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/07 13:04:26 UTC

[GitHub] [flink] leonardBang opened a new pull request #14323: [FLINK-20486][hive] Hive temporal join should allow smaller monitor interval than 1 hour

leonardBang opened a new pull request #14323:
URL: https://github.com/apache/flink/pull/14323


   ## What is the purpose of the change
   
   * Currently we limits the monitor interval should be at least 1 hour to avoid produce pressure to hive meta store, this should be safe in production, but it's inconvenient for demo or simple user case. This pull request to unlock the monitor interval limitation of hive temporal table.
   
   
   ## Brief change log
   
     - update file `org/apache/flink/connectors/hive/HiveLookupTableSource.java`
   
   
   ## Verifying this change
   
   * Add unit test to check monitor interval can be set by users.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14323: [FLINK-20486][hive] Hive temporal join should allow smaller monitor interval than 1 hour

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14323:
URL: https://github.com/apache/flink/pull/14323#issuecomment-739916490


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4146e634deca0a32b5b1638013f62ca8fca546b8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4146e634deca0a32b5b1638013f62ca8fca546b8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4146e634deca0a32b5b1638013f62ca8fca546b8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on pull request #14323: [FLINK-20486][hive] Hive temporal join should allow smaller monitor interval than 1 hour

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #14323:
URL: https://github.com/apache/flink/pull/14323#issuecomment-740315223


   cc @wuchong Could you help review this PR ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14323: [FLINK-20486][hive] Hive temporal join should allow smaller monitor interval than 1 hour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14323:
URL: https://github.com/apache/flink/pull/14323#issuecomment-739916490


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4146e634deca0a32b5b1638013f62ca8fca546b8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10588",
       "triggerID" : "4146e634deca0a32b5b1638013f62ca8fca546b8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4146e634deca0a32b5b1638013f62ca8fca546b8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10588) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #14323: [FLINK-20486][hive] Hive temporal join should allow smaller monitor interval than 1 hour

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14323:
URL: https://github.com/apache/flink/pull/14323


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14323: [FLINK-20486][hive] Hive temporal join should allow smaller monitor interval than 1 hour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14323:
URL: https://github.com/apache/flink/pull/14323#issuecomment-739916490


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4146e634deca0a32b5b1638013f62ca8fca546b8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10588",
       "triggerID" : "4146e634deca0a32b5b1638013f62ca8fca546b8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4146e634deca0a32b5b1638013f62ca8fca546b8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10588) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14323: [FLINK-20486][hive] Hive temporal join should allow smaller monitor interval than 1 hour

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14323:
URL: https://github.com/apache/flink/pull/14323#issuecomment-739906855


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4146e634deca0a32b5b1638013f62ca8fca546b8 (Mon Dec 07 13:06:40 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org