You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/26 14:38:34 UTC

[GitHub] [kafka] lbradstreet commented on a change in pull request #9179: KAFKA-10390: Remove ignore case option when grep process info to be more specific

lbradstreet commented on a change in pull request #9179:
URL: https://github.com/apache/kafka/pull/9179#discussion_r477352942



##########
File path: bin/kafka-server-stop.sh
##########
@@ -21,7 +21,7 @@ if [[ $(uname -s) == "OS/390" ]]; then
     fi
     PIDS=$(ps -A -o pid,jobname,comm | grep -i $JOBNAME | grep java | grep -v grep | awk '{print $1}')
 else
-    PIDS=$(ps ax | grep -i 'kafka\.Kafka' | grep java | grep -v grep | awk '{print $1}')
+    PIDS=$(ps ax | grep 'kafka\.Kafka' | grep java | grep -v grep | awk '{print $1}')

Review comment:
       Is there any reason we can't make it more specific by requiring an exact match with surrounding spaces: `' kafka\.Kafka '`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org