You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/02 08:46:53 UTC

[GitHub] [kafka] mimaison opened a new pull request, #12113: MINOR: Small cleanups in connect/mirror

mimaison opened a new pull request, #12113:
URL: https://github.com/apache/kafka/pull/12113

   - Make a few fields `final`
   - Remove unnecessary `throws`
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #12113: MINOR: Small cleanups in connect/mirror

Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12113:
URL: https://github.com/apache/kafka/pull/12113#issuecomment-1121995342

   Failed tests are unrelated:
   ```
   Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopology
   Build / JDK 8 and Scala 2.12 / kafka.server.KRaftClusterTest.testCreateClusterAndPerformReassignment()
   Build / JDK 11 and Scala 2.13 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] divijvaidya commented on pull request #12113: MINOR: Small cleanups in connect/mirror

Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12113:
URL: https://github.com/apache/kafka/pull/12113#issuecomment-1114739908

   Hey @mimaison, one of the flaky tests failing for this PR is `testListenerConnectionRateLimitWhenActualRateAboveLimit() – kafka.network.ConnectionQuotasTest` which I have fixed as part of https://github.com/apache/kafka/pull/12045 
   
   If you get a chance, please review my PR and that will reduce some degree of flakiness from the existing test suite. 
   
   Thanks in advance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon merged pull request #12113: MINOR: Small cleanups in connect/mirror

Posted by GitBox <gi...@apache.org>.
showuon merged PR #12113:
URL: https://github.com/apache/kafka/pull/12113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org