You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by HorizonNet <gi...@git.apache.org> on 2018/03/24 14:34:37 UTC
[GitHub] zeppelin pull request #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j...
GitHub user HorizonNet opened a pull request:
https://github.com/apache/zeppelin/pull/2892
ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
### What is this PR for?
Fixed the Checkstyle errors and warnings in the neo4j module.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3162
### How should this be tested?
* CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ultratendency/zeppelin ZEPPELIN-3162
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2892
----
commit 819a1a242fea63de17bf99761b7192e09ce2d0be
Author: Jan Hentschel <ja...@...>
Date: 2018-03-24T13:31:52Z
ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
----
---
[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2892
one test failed, could you check?
---
[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
Posted by HorizonNet <gi...@git.apache.org>.
Github user HorizonNet commented on the issue:
https://github.com/apache/zeppelin/pull/2892
I'm currently re-running all the failing PRs.
---
[GitHub] zeppelin pull request #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2892
---
[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2892
seems like test fail for unrelated reason - is it out of date or something?
```
[WARNING] The requested profile "hadoop2" could not be activated because it does not exist.
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm test) on project zeppelin-web: Failed to run task: 'npm run test' failed. (error code 1) -> [Help 1]
```
---
[GitHub] zeppelin pull request #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j...
Posted by HorizonNet <gi...@git.apache.org>.
Github user HorizonNet closed the pull request at:
https://github.com/apache/zeppelin/pull/2892
---
[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
Posted by HorizonNet <gi...@git.apache.org>.
Github user HorizonNet commented on the issue:
https://github.com/apache/zeppelin/pull/2892
I merged the latest master into this branch. Let's wait for the build.
---
[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2892
merging if no more comment
---
[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
Posted by HorizonNet <gi...@git.apache.org>.
Github user HorizonNet commented on the issue:
https://github.com/apache/zeppelin/pull/2892
Reverted `zeppelin-web/package-lock.json` to the one from the `master` branch.
---
[GitHub] zeppelin pull request #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j...
Posted by HorizonNet <gi...@git.apache.org>.
GitHub user HorizonNet reopened a pull request:
https://github.com/apache/zeppelin/pull/2892
ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
### What is this PR for?
Fixed the Checkstyle errors and warnings in the neo4j module.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3162
### How should this be tested?
* CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ultratendency/zeppelin ZEPPELIN-3162
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2892
----
commit 819a1a242fea63de17bf99761b7192e09ce2d0be
Author: Jan Hentschel <ja...@...>
Date: 2018-03-24T13:31:52Z
ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module
commit cf951102cdce5c11488c63efcdfb7f326048a728
Author: Jan Hentschel <ja...@...>
Date: 2018-03-25T20:30:42Z
ZEPPELIN-3162. Incorporated review feedback
commit 2d628c9b80c6112d42530b9b2234f1d298feb920
Author: Jan Hentschel <ja...@...>
Date: 2018-03-26T09:09:52Z
Merge branch 'master' into ZEPPELIN-3162
commit d8c2f49161f93d5fd481d0b5447d2d844b1802f4
Author: Jan Hentschel <ja...@...>
Date: 2018-03-27T10:24:44Z
ZEPPELIN-3162. Reverted package-lock.json
----
---