You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "wt-better (via GitHub)" <gi...@apache.org> on 2024/03/02 05:28:13 UTC
[PR] feature: tcc compatible [incubator-seata]
wt-better opened a new pull request, #6387:
URL: https://github.com/apache/incubator-seata/pull/6387
- [ ] I have registered the PR [changes](../changes).
io.seata tcc api compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: tcc compatible [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6387:
URL: https://github.com/apache/incubator-seata/pull/6387#discussion_r1517734245
##########
compatible/src/test/java/io/seata/rm/tcc/interceptor/ProxyUtilsTccTest.java:
##########
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.seata.rm.tcc.interceptor;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+import io.seata.rm.tcc.NormalTccActionImpl;
+import io.seata.rm.tcc.TccParam;
+import org.apache.seata.core.context.RootContext;
Review Comment:
```suggestion
import io.seata.core.context.RootContext;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: tcc compatible [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6387:
URL: https://github.com/apache/incubator-seata/pull/6387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] feature: tcc compatible [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6387:
URL: https://github.com/apache/incubator-seata/pull/6387#issuecomment-1974383170
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `78.78788%` with `7 lines` in your changes are missing coverage. Please review.
> Project coverage is 51.07%. Comparing base [(`575ac12`)](https://app.codecov.io/gh/apache/incubator-seata/commit/575ac12355e8747d426e900eb6b4cc58b8210354?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3b9d1f8`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6387 +/- ##
============================================
+ Coverage 51.01% 51.07% +0.06%
- Complexity 5261 5265 +4
============================================
Files 934 933 -1
Lines 33029 33019 -10
Branches 4002 4000 -2
============================================
+ Hits 16849 16864 +15
+ Misses 14511 14491 -20
+ Partials 1669 1664 -5
```
| [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/seata/spring/tcc/TccAnnotationProcessor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3ByaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zcHJpbmcvdGNjL1RjY0Fubm90YXRpb25Qcm9jZXNzb3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...m/tcc/interceptor/TccActionInterceptorHandler.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9ybS90Y2MvaW50ZXJjZXB0b3IvVGNjQWN0aW9uSW50ZXJjZXB0b3JIYW5kbGVyLmphdmE=) | `67.14% <78.78%> (-1.71%)` | :arrow_down: |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6387/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: tcc compatible [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6387:
URL: https://github.com/apache/incubator-seata/pull/6387#discussion_r1517772251
##########
changes/zh-cn/2.x.md:
##########
@@ -111,6 +111,7 @@
- [[#6386](https://github.com/apache/incubator-seata/pull/6386)] 在 `ConfigurationCache` 类中，将 `byte-buddy` 替换为JDK代理
- [[#6391](https://github.com/apache/incubator-seata/pull/6091)] 禁止重复注册TCC资源
- [[#6393](https://github.com/apache/incubator-seata/pull/6393)] 元数据同步前判断版本,并增加重试功能
+- [[#6387](https://github.com/apache/incubator-seata/pull/6387)] 包重命名 tcc使用兼容
Review Comment:
```suggestion
- [[#6387](https://github.com/apache/incubator-seata/pull/6387)] 优化tcc使用兼容
```
##########
changes/en-us/2.x.md:
##########
@@ -107,6 +107,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6386](https://github.com/apache/incubator-seata/pull/6386)] replace `byte-buddy` to JDK proxy in `ConfigurationCache`
- [[#6391](https://github.com/apache/incubator-seata/pull/6091)] forbid duplicate registration of TCC resources
- [[#6393](https://github.com/apache/incubator-seata/pull/6393)] determine the version before sync metadata and add retry mechanism
+- [[#6387](https://github.com/apache/incubator-seata/pull/6387)] package rename, tcc use compatible
Review Comment:
```suggestion
- [[#6387](https://github.com/apache/incubator-seata/pull/6387)] optimize tcc use compatible
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org