You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by justinleet <gi...@git.apache.org> on 2017/02/01 03:15:46 UTC
[GitHub] incubator-metron pull request #431: METRON-680: GeoLiteDatabase incorrectly ...
GitHub user justinleet opened a pull request:
https://github.com/apache/incubator-metron/pull/431
METRON-680: GeoLiteDatabase incorrectly using country geoname_id instead of city
See the discussion [METRON-680]( https://issues.apache.org/jira/browse/METRON-680) for more info. This implements the easy country -> city change. The two fields have the exact same format (they're both ids from geonames.org)
The main concern I have is what happens given that that the "Unique-Location(s)" visualization in Kibana uses locId directly. Changing what gets passed to it affects what shows up in that field.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/incubator-metron METRON-680
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #431
----
commit 8cd13f44d9c23c6355f21f46284a42ddf55885f9
Author: justinjleet <ju...@gmail.com>
Date: 2017-02-01T03:07:31Z
METRON-680: GeoLiteDatabase incorrectly using country geoname_id instead of city
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #431: METRON-680: GeoLiteDatabase incorrectly ...
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet closed the pull request at:
https://github.com/apache/incubator-metron/pull/431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---