You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by fi...@apache.org on 2001/01/28 08:41:15 UTC

cvs commit: httpd-2.0 CHANGES acinclude.m4 configure.in

fielding    01/01/27 23:41:15

  Modified:    .        CHANGES acinclude.m4 configure.in
  Log:
  Replace configure --with-optim option by using and saving the
  environment variable OPTIM instead.  This is needed because configure
  options do not support multiple flags separated by spaces.
  
  Revision  Changes    Path
  1.62      +5 -0      httpd-2.0/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/CHANGES,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -r1.61 -r1.62
  --- CHANGES	2001/01/28 04:07:02	1.61
  +++ CHANGES	2001/01/28 07:41:15	1.62
  @@ -1,5 +1,10 @@
   Changes with Apache 2.0b1
   
  +  *) Replace configure --with-optim option by using and saving the
  +     environment variable OPTIM instead.  This is needed because configure
  +     options do not support multiple flags separated by spaces.
  +     [Roy Fielding]
  +
     *) Fix some byterange handling.  If we get a byte range that looks like
        "-999999" where that is past the end of the file, we should return 
        a PARTIAL CONTENT status code, and return the whole file as one big
  
  
  
  1.63      +3 -0      httpd-2.0/acinclude.m4
  
  Index: acinclude.m4
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/acinclude.m4,v
  retrieving revision 1.62
  retrieving revision 1.63
  diff -u -r1.62 -r1.63
  --- acinclude.m4	2001/01/21 17:22:16	1.62
  +++ acinclude.m4	2001/01/28 07:41:15	1.63
  @@ -7,6 +7,9 @@
   # Created by configure
   
   EOF
  +  if test -n "$OPTIM"; then
  +    echo "OPTIM=\"$OPTIM\"; export OPTIM" >> $1
  +  fi
   
     for arg in [$]0 "[$]@"; do
       echo "\"[$]arg\" \\" >> $1
  
  
  
  1.117     +2 -2      httpd-2.0/configure.in
  
  Index: configure.in
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/configure.in,v
  retrieving revision 1.116
  retrieving revision 1.117
  diff -u -r1.116 -r1.117
  --- configure.in	2001/01/28 06:46:23	1.116
  +++ configure.in	2001/01/28 07:41:15	1.117
  @@ -111,8 +111,8 @@
   AC_CHECK_LIB(nsl, gethostname)
   AC_CHECK_LIB(socket, socket)
   
  -AC_ARG_WITH(optim,[  --with-optim="FLAGS"      compiler optimisation flags],
  -        [if test "$withval" = "yes"; then AC_MSG_ERROR('option --with-optim requires a value (the optimisation flags)'); else OPTIM="$withval"; fi])
  +AC_ARG_WITH(optim,[  --with-optim="FLAG"      obsolete (use env OPTIM)],
  +        [AC_MSG_ERROR('option --with-optim is obsolete; use OPTIM environment variable instead')])
   
   AC_ARG_WITH(port,[  --with-port=PORT        Port on which to listen (default is 80)],
           [if test "$withval" = "yes"; then AC_MSG_ERROR('option --with-port requires a value (the TCP port number)'); else PORT="$withval"; fi],
  
  
  

Re: cvs commit: httpd-2.0 CHANGES acinclude.m4 configure.in

Posted by rb...@covalent.net.
> > > Aha! Does it indeed? Marvellous. And does this propogate down through
> > > _all_ the different configures?
> > 
> > I thought it did (I checked for apr), but it looks like it isn't
> > being propagated to support.  Easy enough to fix.
> 
> Argh!  Why do we have a different way of setting flags in every
> friggin module?  EVERYTHING should be using the APR build stuff.
> I'm too tired to figure out how to follow the build logic and
> get OPTIM working everywhere.  Maybe when I wake up.

Because we wrote the APR stuff after the Apache stuff, and we didn't
change the Apache stuff.

Ryan
_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Re: cvs commit: httpd-2.0 CHANGES acinclude.m4 configure.in

Posted by "Roy T. Fielding" <fi...@ebuilt.com>.
On Sun, Jan 28, 2001 at 03:47:52AM -0500, Roy T. Fielding wrote:
> > Aha! Does it indeed? Marvellous. And does this propogate down through
> > _all_ the different configures?
> 
> I thought it did (I checked for apr), but it looks like it isn't
> being propagated to support.  Easy enough to fix.

Argh!  Why do we have a different way of setting flags in every
friggin module?  EVERYTHING should be using the APR build stuff.
I'm too tired to figure out how to follow the build logic and
get OPTIM working everywhere.  Maybe when I wake up.

....Roy

Re: cvs commit: httpd-2.0 CHANGES acinclude.m4 configure.in

Posted by "Roy T. Fielding" <fi...@ebuilt.com>.
> Aha! Does it indeed? Marvellous. And does this propogate down through
> _all_ the different configures?

I thought it did (I checked for apr), but it looks like it isn't
being propagated to support.  Easy enough to fix.

....Roy

Re: cvs commit: httpd-2.0 CHANGES acinclude.m4 configure.in

Posted by Ben Laurie <be...@algroup.co.uk>.
"Roy T. Fielding" wrote:
> 
> >   Replace configure --with-optim option by using and saving the
> >   environment variable OPTIM instead.  This is needed because configure
> >   options do not support multiple flags separated by spaces.
> 
> This also makes it easy to specify -Werror via
> 
>    env OPTIM="-O -Werror" ./configure ...

Aha! Does it indeed? Marvellous. And does this propogate down through
_all_ the different configures?

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Re: cvs commit: httpd-2.0 CHANGES acinclude.m4 configure.in

Posted by "Roy T. Fielding" <fi...@ebuilt.com>.
>   Replace configure --with-optim option by using and saving the
>   environment variable OPTIM instead.  This is needed because configure
>   options do not support multiple flags separated by spaces.

This also makes it easy to specify -Werror via

   env OPTIM="-O -Werror" ./configure ...

....Roy