You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/05/07 04:44:40 UTC

[GitHub] [phoenix] swaroopak commented on a change in pull request #499: Phoenix 4703 ALTER INDEX REBUILD ALL

swaroopak commented on a change in pull request #499: Phoenix 4703 ALTER INDEX REBUILD ALL 
URL: https://github.com/apache/phoenix/pull/499#discussion_r281459101
 
 

 ##########
 File path: phoenix-core/src/main/antlr3/PhoenixSQL.g
 ##########
 @@ -606,8 +606,8 @@ drop_index_node returns [DropIndexStatement ret]
 // Parse a alter index statement
 alter_index_node returns [AlterIndexStatement ret]
     : ALTER INDEX (IF ex=EXISTS)? i=index_name ON t=from_table_name
-      ((s=(USABLE | UNUSABLE | REBUILD | DISABLE | ACTIVE)) (async=ASYNC)? ((SET?)p=fam_properties)?)
-      {ret = factory.alterIndex(factory.namedTable(null, TableName.create(t.getSchemaName(), i.getName())), t.getTableName(), ex!=null, PIndexState.valueOf(SchemaUtil.normalizeIdentifier(s.getText())), async!=null, p); }
+      ((s=(USABLE | UNUSABLE | REBUILD | DISABLE | ACTIVE)) (all=ALL)? (async=ASYNC)? ((SET?)p=fam_properties)?)
 
 Review comment:
   Grammar seems misleading. We are expecting ALL only after REBUILD keyword. Shouldn't it be a part of REBUILD or condition, as we don't support ALL on any other keyword like USABLE | DISABLE etc?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services