You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/06/03 07:17:14 UTC

[GitHub] [drill] martin-g commented on pull request #2246: DRILL-7943 Update Hamcrest to 2.2

martin-g commented on pull request #2246:
URL: https://github.com/apache/drill/pull/2246#issuecomment-853636660


   >  Just curious but is there a reason why we don't just use `junit` and remove this dependency altogether?
   
   JUnit provides just `Assert.assertThat(String reason, T actual, Matcher<? super T> matcher)`, Hamcrest provides the actual matcher implementations. 
   
   JUnit's `assertThat()` is linked to Hamcrest 1.3 Matcher. This is the reason to replace it with `org.hamcrest.MatcherAssert.assertThat()` in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org