You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@mynewt.apache.org by "94xhn (via GitHub)" <gi...@apache.org> on 2026/08/19 13:20:15 UTC

Re: [PR] os_dev: add boundary check on od_open_ref [mynewt-core]

94xhn commented on PR #3709:
URL: https://github.com/apache/mynewt-core/pull/3709#issuecomment-5342714514

   You're right, that guard didn't make sense in context of the actual bug (#1457) -- it was defending against 256+ unmatched opens, which isn't a scenario that happens with real device usage in this tree, and it wasn't what was reported. Removed it in 60ccaae, keeping just the close-side od_open_ref==0 check, which is what actually fixes the reported underflow-on-double-close.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org