You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2025/11/27 21:26:34 UTC

[PR] [CI] pre-commit autoupdate; run pre-commit [sedona]

jbampton opened a new pull request, #2538:
URL: https://github.com/apache/sedona/pull/2538

   Clean up the pre-commit config fixing indentation and using more readable multiline regex
   
   After updating the pre-commit version of clang-format we had some new formatting changes in c and h files.
   
   Added an ignore in the markdownlint config for MD060 a new rule.
   
   https://nodejs.org/en/download
   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - No:
     - this is a CI update. The PR name follows the format `[CI] my subject`
   
   ## What changes were proposed in this PR?
   
   As described above
   
   ## How was this patch tested?
   
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CI] pre-commit autoupdate; run pre-commit [sedona]

Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #2538:
URL: https://github.com/apache/sedona/pull/2538#issuecomment-3643577137

   On my local machine I ran: `clang-format -style=Google -dump-config > .clang-format`
   
   Then edited two lines in the `.clang-format` file to align the pointer to the right.
   
   And I removed the argument for "Style Google" from the clang format hook.
   
   ```
   # .clang-format
   DerivePointerAlignment: false
   PointerAlignment: Right
   ```
   
   Updated the pre-commit config again it moves quickly
   
   https://nodejs.org/en/download
   
   https://www.npmjs.com/package/prettier


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CI] pre-commit autoupdate; run pre-commit [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #2538:
URL: https://github.com/apache/sedona/pull/2538#issuecomment-3605172484

   OK. @jbampton Can we stick to the old format?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CI] pre-commit autoupdate; run pre-commit [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #2538:
URL: https://github.com/apache/sedona/pull/2538


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org