[GitHub] [druid] kfaraz commented on a diff in pull request #12611: Change error message to be more specific

[GitBox <gi...@apache.org>]

kfaraz commented on code in PR #12611:
URL: https://github.com/apache/druid/pull/12611#discussion_r889860228


##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java:
##########
@@ -694,15 +694,15 @@ private String validateAndGetDataSourceForIngest(final SqlInsert insert) throws
     }
 
     if (insert.getTargetColumnList() != null) {
-      throw new ValidationException("Ingestion with target column list is not supported.");
+      throw new ValidationException(insert.getOperator().getName() + " with target column list is not supported.");

Review Comment:
   `insert.getOperator().getName()` is being used in several places.
   Maybe assign it to a variable 
   `final String insertOperatorName = insert.getOperator().getName();`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org