You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/05/27 00:19:39 UTC
[GitHub] [spark] beliefer commented on a diff in pull request #41311: [SPARK-43792][SQL][PYTHON][CONNECT] Add optional pattern for Catalog.listCatalogs
beliefer commented on code in PR #41311:
URL: https://github.com/apache/spark/pull/41311#discussion_r1207507283
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -639,4 +639,12 @@ abstract class Catalog {
* @since 3.5.0
*/
def listCatalogs(): Dataset[CatalogMetadata]
+
+ /**
+ * Returns a list of catalogs which name match the specify pattern and available in this
+ * session.
+ *
+ * @since 3.5.0
+ */
+ def listCatalogs(pattern: String): Dataset[CatalogMetadata]
Review Comment:
If we can, I think it's OK too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org