You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ponymail.apache.org by GitBox <gi...@apache.org> on 2020/08/15 06:21:40 UTC

[GitHub] [incubator-ponymail] Humbedooh opened a new pull request #518: convertToWrapped expects a bytestring

Humbedooh opened a new pull request #518:
URL: https://github.com/apache/incubator-ponymail/pull/518


   Additionally, be more specific in our format=flowed search


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail] Humbedooh commented on pull request #518: convertToWrapped expects a bytestring

Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #518:
URL: https://github.com/apache/incubator-ponymail/pull/518#issuecomment-675124817


   or perhaps the formatflowed.decode() option is better suited instead of convertToWrapped...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail] Humbedooh commented on pull request #518: convertToWrapped expects a bytestring

Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #518:
URL: https://github.com/apache/incubator-ponymail/pull/518#issuecomment-675122518


   Would it be better to look into rolling our own converter? The codebase looks very simple.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail] sebbASF commented on pull request #518: convertToWrapped expects a bytestring

Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #518:
URL: https://github.com/apache/incubator-ponymail/pull/518#issuecomment-680227488


   I found a few cases where the first convertToWrapped call actually worked.
   So I think the solution is to leave the current code exactly as is so id generation is not affected.
   
   Once the id has been calculated, the body can be reformatted as necessary for storage in the database.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail] asfgit closed pull request #518: convertToWrapped expects a bytestring

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #518:
URL: https://github.com/apache/incubator-ponymail/pull/518


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail] sebbASF commented on pull request #518: convertToWrapped expects a bytestring

Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #518:
URL: https://github.com/apache/incubator-ponymail/pull/518#issuecomment-675078245


   -1, as this changes the  source used for hash generation. This will break most of the existing generators.
   
   If it is desired to apply the reformatting, it needs to be done *after* the MID calculation.
   
   However note that in my experiments, the reformatting causes badly wrapped output.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail] sebbASF commented on pull request #518: convertToWrapped expects a bytestring

Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #518:
URL: https://github.com/apache/incubator-ponymail/pull/518#issuecomment-675139928


   I think we need to gather some test cases.
   
   There are quite a few instances of format=flowed in the unit test corpus file users_httpd_apache_org_2020-07.mbox, however they don't seem to be the sort of messages that need to be wrapped.
   
   Note: I got better results by specifying ' wrap_fixed=False' on the above corpus.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org