You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2016/04/17 18:47:41 UTC
Review Request 46308: Moved LogProcess declaration to log/log.h.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46308/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171
Repository: mesos
Description
-------
Moved LogProcess declaration to log/log.h.
Diffs
-----
include/mesos/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896
src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99
src/log/log.hpp PRE-CREATION
src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42
Diff: https://reviews.apache.org/r/46308/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 46308: Moved LogProcess declaration to log/log.h.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46308/#review129595
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 17, 2016, 4:47 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46308/
> -----------------------------------------------------------
>
> (Updated April 17, 2016, 4:47 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved LogProcess declaration to log/log.h.
>
>
> Diffs
> -----
>
> include/mesos/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896
> src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99
> src/log/log.hpp PRE-CREATION
> src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42
>
> Diff: https://reviews.apache.org/r/46308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 46308: Moved LogProcess declaration to log/log.h.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46308/#review129269
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45900, 45901, 46160, 46161, 46162, 46163, 46164, 46288, 46295, 46308]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 17, 2016, 4:47 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46308/
> -----------------------------------------------------------
>
> (Updated April 17, 2016, 4:47 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved LogProcess declaration to log/log.h.
>
>
> Diffs
> -----
>
> include/mesos/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896
> src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99
> src/log/log.hpp PRE-CREATION
> src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42
>
> Diff: https://reviews.apache.org/r/46308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>