[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3526: [KYUUBI #3500] Supply TPC data initialization SQL script for Kyuubi playground

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #3526:
URL: https://github.com/apache/incubator-kyuubi/pull/3526#discussion_r975101518


##########
docker/playground/compose.yml:
##########
@@ -78,3 +78,15 @@ services:
       - metastore
       - minio
       - zookeeper
+
+  kyuubi-client:
+    image: nekyuubi/kyuubi-playground-kyuubi:${KYUUBI_VERSION}
+    container_name: kyuubi-client
+    hostname: kyuubi-client
+    volumes:
+      - ./image/load-dataset-tpcds-tiny.sql:/etc/kyuubi/conf/load-dataset-tpcds-tiny.sql
+      - ./image/load-dataset-tpch-tiny.sql:/etc/kyuubi/conf/load-dataset-tpch-tiny.sql
+      - ./image/load-dataset.sh:/opt/kyuubi/bin/load-dataset.sh

Review Comment:
   we should not put the scripts to `/opt/kyuubi/bin`, it may confuse users. 
   let's put them into `/opt/bin` instead



##########
docker/playground/image/load-dataset-tpch-tiny.sql:
##########
@@ -0,0 +1,61 @@
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+SET tiny_schema=tpch.tiny;
+
+CREATE DATABASE IF NOT EXISTS tpchtiny;
+
+USE tpchtiny;

Review Comment:
   tpch_tiny



##########
docker/playground/image/load-dataset-tpcds-tiny.sql:
##########
@@ -0,0 +1,148 @@
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+SET tiny_schema=tpcds.tiny;
+
+CREATE DATABASE IF NOT EXISTS tpcdstiny;
+
+USE tpcdstiny;

Review Comment:
   tpcds_tiny



##########
docker/playground/compose.yml:
##########
@@ -78,3 +78,15 @@ services:
       - metastore
       - minio
       - zookeeper
+
+  kyuubi-client:

Review Comment:
   it's unnecessary to create a new container as the client, we can reuse the server one.
   ```
   docker exec -it kyuubi /opt/kyuubi/bin/beeline -u 'jdbc:hive2://0.0.0.0:10009/'
   ```



##########
docker/playground/image/load-dataset.sh:
##########
@@ -0,0 +1,50 @@
+#!/usr/bin/env bash

Review Comment:
   we don't need that, let's guide users to use
   ```
   docker exec -it kyuubi /opt/kyuubi/bin/beeline -u 'jdbc:hive2://0.0.0.0:10009/ -f <xxx.sql>' 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org