You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/03 21:47:32 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

gustavonihei commented on code in PR #7472:
URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1013425999


##########
arch/xtensa/src/esp32s2/esp32s2_spi.c:
##########
@@ -1432,8 +1432,6 @@ static void esp32s2_spi_init(struct spi_dev_s *dev)
 
 #if defined(CONFIG_ESP32S2_SPI2_DMA) || defined(CONFIG_ESP32S2_SPI3_DMA)
   nxsem_init(&priv->sem_isr, 0, 0);

Review Comment:
   Shouldn't this be removed?
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org