[GitHub] [calcite] zinking commented on a diff in pull request #3125: [CALCITE-5449] Allow EXTRACT() to accept DAYOFWEEK, DAYOFYEAR, ISOWEEK, WEEK(WEEKDAY)

["zinking (via GitHub)" <gi...@apache.org>]

zinking commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175109369


##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -398,14 +398,12 @@ SELECT
 # In the following example, EXTRACT returns values corresponding to
 # different date parts from a column of dates near the end of the
 # year.
-
-!if (false) {
 SELECT
   d,
   EXTRACT(ISOYEAR FROM d) AS isoyear,
-  EXTRACT(ISOWEEK FROM d) AS isoweek,
-  EXTRACT(YEAR FROM d) AS year,
-  EXTRACT(WEEK FROM d) AS week
+  EXTRACT(ISOWEEK FROM d) as isoweek,
+  EXTRACT(WEEK(TUESDAY) FROM d) AS week_tues,

Review Comment:
   can you add new columns instead of overriding existing column ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org