You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by jo...@apache.org on 2010/06/23 20:25:39 UTC

svn commit: r957292 - /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java

Author: johnh
Date: Wed Jun 23 18:25:39 2010
New Revision: 957292

URL: http://svn.apache.org/viewvc?rev=957292&view=rev
Log:
ProxyBase.setRequestHeaders() throws GadgetException, for easier overriding.

All calling locations already throw GadgetException anyway, so no modifications needed on that side.

Patch/idea provided and suggested by Jan Luehe.


Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java?rev=957292&r1=957291&r2=957292&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java Wed Jun 23 18:25:39 2010
@@ -147,7 +147,8 @@ public abstract class ProxyBase {
     }
   }
 
-  protected void setRequestHeaders(HttpServletRequest servletRequest, HttpRequest req) {
+  protected void setRequestHeaders(HttpServletRequest servletRequest, HttpRequest req)
+      throws GadgetException {
     String xff  = servletRequest.getHeader("X-Forwarded-For");
     String remoteAddr = servletRequest.getRemoteAddr();
     if (!StringUtils.isEmpty(remoteAddr)) {