[GitHub] [superset] villebro edited a comment on pull request #13163: fix: Fixing pinot query generation for date format conversion from python datetime format to java simple date format

[GitBox <gi...@apache.org>]

villebro edited a comment on pull request #13163:
URL: https://github.com/apache/superset/pull/13163#issuecomment-781141621


   > it's already there on line 72 for pdf check and line 99 for time_grain check.
   
   Yes, I meant a simple unit test to test for those lines (sorry for being unclear). The reason I'm asking is Pinot is a fairly different connector compared to others, so I'd like to make sure we have good coverage for it to guard against regressions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org