You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/11 23:32:15 UTC
Review Request 59216: Fixed some inaccurate comments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59216/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6977
https://issues.apache.org/jira/browse/MESOS-6977
Repository: mesos
Description
-------
Orphan tasks/executors are still possible in Mesos 1.2.0; they are not
possible with Mesos 1.2.1 or Mesos >= 1.3.0.
Diffs
-----
include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367
Diff: https://reviews.apache.org/r/59216/diff/1/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 59216: Fixed some inaccurate comments.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59216/
-----------------------------------------------------------
(Updated May 15, 2017, 11:16 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Clarified comments.
Bugs: MESOS-6977
https://issues.apache.org/jira/browse/MESOS-6977
Repository: mesos
Description
-------
Orphan tasks/executors are still possible in Mesos 1.2.0; they are not
possible with Mesos 1.2.1 or Mesos >= 1.3.0.
Diffs (updated)
-----
include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367
Diff: https://reviews.apache.org/r/59216/diff/2/
Changes: https://reviews.apache.org/r/59216/diff/1-2/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 59216: Fixed some inaccurate comments.
Posted by Neil Conway <ne...@gmail.com>.
> On May 12, 2017, 9:37 p.m., Benjamin Mahler wrote:
> > include/mesos/master/master.proto
> > Line 382 (original), 382 (patched)
> > <https://reviews.apache.org/r/59216/diff/1/?file=1716305#file1716305line382>
> >
> > Why not add the deprecation tag here and for tasks?
> >
> > ```
> > repeated Task orphan_executors = 4 [deprecated = true];
> > ```
I did this in a separate review: https://reviews.apache.org/r/59301/
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59216/#review174852
-----------------------------------------------------------
On May 15, 2017, 11:16 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59216/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 11:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Orphan tasks/executors are still possible in Mesos 1.2.0; they are not
> possible with Mesos 1.2.1 or Mesos >= 1.3.0.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367
>
>
> Diff: https://reviews.apache.org/r/59216/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59216: Fixed some inaccurate comments.
Posted by Neil Conway <ne...@gmail.com>.
> On May 12, 2017, 9:37 p.m., Benjamin Mahler wrote:
> > include/mesos/master/master.proto
> > Lines 380-381 (original), 380-381 (patched)
> > <https://reviews.apache.org/r/59216/diff/1/?file=1716305#file1716305line380>
> >
> > Just to clarify the intent of this comment, our deprecation cycle technically means that we can't remove this until 2.0, right?
Clarified these comments.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59216/#review174852
-----------------------------------------------------------
On May 15, 2017, 11:16 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59216/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 11:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Orphan tasks/executors are still possible in Mesos 1.2.0; they are not
> possible with Mesos 1.2.1 or Mesos >= 1.3.0.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367
>
>
> Diff: https://reviews.apache.org/r/59216/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59216: Fixed some inaccurate comments.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59216/#review174852
-----------------------------------------------------------
Fix it, then Ship it!
Any reason not to be adding the deprecated tag here?
include/mesos/master/master.proto
Line 378 (original), 378 (patched)
<https://reviews.apache.org/r/59216/#comment248069>
and is deprecated? Ditto for tasks
include/mesos/master/master.proto
Lines 380-381 (original), 380-381 (patched)
<https://reviews.apache.org/r/59216/#comment248070>
Just to clarify the intent of this comment, our deprecation cycle technically means that we can't remove this until 2.0, right?
include/mesos/master/master.proto
Line 382 (original), 382 (patched)
<https://reviews.apache.org/r/59216/#comment248068>
Why not add the deprecation tag here and for tasks?
```
repeated Task orphan_executors = 4 [deprecated = true];
```
- Benjamin Mahler
On May 11, 2017, 11:32 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59216/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 11:32 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Orphan tasks/executors are still possible in Mesos 1.2.0; they are not
> possible with Mesos 1.2.1 or Mesos >= 1.3.0.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367
>
>
> Diff: https://reviews.apache.org/r/59216/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>