You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by m4rkmckenna <gi...@git.apache.org> on 2015/11/13 02:26:43 UTC
[GitHub] incubator-brooklyn pull request: Adding missing ASF license header...
GitHub user m4rkmckenna opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1028
Adding missing ASF license headers to test-framework
The `test-framework` was using an incorrect parent pom so the `apache-rat-plugin` did not fail the build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/m4rkmckenna/incubator-brooklyn adding-missing-headers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1028.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1028
----
commit 07fbd2a927041c7af6315a1b49d636e4c12e0823
Author: Mark McKenna <m4...@gmail.com>
Date: 2015-11-13T01:09:22Z
Added ASF Licence Header
* Fix for test-framework using incorrect parent pom 'brooklyn' -> 'brooklyn-parent'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adding missing ASF license header...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1028
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adding missing ASF license header...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1028#issuecomment-156295969
@ahgittin The markdown files caught me out :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adding missing ASF license header...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1028#issuecomment-156301377
happens to me all the time :) . it especially annoys me that the rat plugin doesn't log the offending files to stdout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adding missing ASF license header...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1028#issuecomment-156293876
Looks like there are other files missing headers:
https://builds.apache.org/job/incubator-brooklyn-pull-requests/2126/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adding missing ASF license header...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1028#issuecomment-156371764
Thanks @m4rkmckenna - that was an extremely quick response!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---