You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vldmrrr <gi...@git.apache.org> on 2016/01/16 18:01:56 UTC
[GitHub] cordova-plugin-camera pull request: CB-10370: Added option useGeol...
GitHub user vldmrrr opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/153
CB-10370: Added option useGeolocation. Also fixed saving geolocation.
While adding the option I found that saving geolocation was broken - result was returned to javascript before location manager code had a chance to update image data. The fix for that is included. I am not sure if a separate CB needed for that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vldmrrr/cordova-plugin-camera CB-10370
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit 6029cbc3ec92fd3f4b3b6b8b49a8595916595783
Author: Vladimir Avdonin <vl...@gmail.com>
Date: 2016-01-16T16:56:35Z
Fixed saving geolocation on iOS. Added option useGeolocation to specify saving geotags programmatically.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10370: Added option useGeol...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/153#issuecomment-218893492
This code has some merge conflicts. It makes sense to move away from a preference and use an option. Also, now the docs for plugin-camera are generated using jsdoc comments. It's best to close this PR and re-create a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org