You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/21 15:33:58 UTC

[GitHub] [iotdb] weizihan0110 commented on a change in pull request #2543: fail to create timeseries when set invalid sdt parameters

weizihan0110 commented on a change in pull request #2543:
URL: https://github.com/apache/iotdb/pull/2543#discussion_r561975415



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -237,6 +242,58 @@ MeasurementMNode createTimeseries(PartialPath path, TSDataType dataType, TSEncod
     }
   }
 
+  //check if sdt parameters are valid
+  private void checkSDTFormat(PartialPath path, Map<String, String> props) throws IOException {
+    String s = "Failed to create timeseries.";
+
+    if (!props.containsKey("compdev")) {

Review comment:
       Hi, something like "compdev" should not be hard-code. It's better to extract them to be a variable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org