You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/27 10:01:23 UTC
[GitHub] [flink] yangjunhan opened a new pull request, #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
yangjunhan opened a new pull request, #20380:
URL: https://github.com/apache/flink/pull/20380
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
As a follow-up step of FLIP-168 and FLIP-224, the Flink Web UI now needs to be enhanced to display the related information if the speculative execution mechanism is enabled. This PR enhances the web UI for the newly adopted API changes.
## Brief change log
- show blocked free slots and blocked TM in overview
- show blocked badge in TM list and detail pages
- enable expanded rows of other concurrent attempts for subtasks
- others: replace loading icon with text to avoid spin animation bottleneck
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simplejason commented on a diff in pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
simplejason commented on code in PR #20380:
URL: https://github.com/apache/flink/pull/20380#discussion_r933797678
##########
flink-runtime-web/web-dashboard/src/app/pages/overview/statistic/overview-statistic.component.less:
##########
@@ -17,50 +17,56 @@
*/
@import "theme";
-nz-card {
- ::ng-deep {
- .ant-card-head {
- border-bottom: 0;
- }
+:host {
+ nz-card {
+ ::ng-deep {
+ .ant-card-head {
+ border-bottom: 0;
+ }
- .ant-card-body {
- padding: 0 24px 8px;
+ .ant-card-body {
+ padding: 0 24px 8px;
+ }
}
}
-}
-.total {
- color: @success-color;
- font-size: 36px;
- line-height: 38px;
-}
-
-.footer {
- margin-top: 16px;
- padding-top: 9px;
- border-top: 1px solid @border-color-split;
+ .total {
+ color: @success-color;
+ font-size: 36px;
+ line-height: 38px;
+ }
- .field {
- display: inline-block;
- font-size: 14px;
- line-height: 22px;
+ .footer {
+ margin-top: @margin-md;
+ padding-top: @padding-sm;
+ border-top: 1px solid @border-color-split;
Review Comment:
nit: I'd like to use variables like `@border-width-base` .etc. to make the code style uniform :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk closed pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
zhuzhurk closed pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
URL: https://github.com/apache/flink/pull/20380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20380:
URL: https://github.com/apache/flink/pull/20380#issuecomment-1196536268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34d390b3d242a446643f2e020555a649c833ea49",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34d390b3d242a446643f2e020555a649c833ea49",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34d390b3d242a446643f2e020555a649c833ea49 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangjunhan commented on pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
yangjunhan commented on PR #20380:
URL: https://github.com/apache/flink/pull/20380#issuecomment-1200789930
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simplejason commented on a diff in pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
simplejason commented on code in PR #20380:
URL: https://github.com/apache/flink/pull/20380#discussion_r933797173
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.html:
##########
@@ -63,9 +63,18 @@
</thead>
<tbody>
<ng-template nz-virtual-scroll let-data>
- <ng-container *ngIf="narrowLogData(data) as subtask">
+ <ng-container *ngIf="narrowType(data) as subtask">
<tr>
- <td>{{ subtask['subtask'] }}</td>
+ <td
+ [nzShowExpand]="subtask['other-concurrent-attempts']?.length > 0"
+ [nzExpand]="expandSet.has(subtask['subtask'])"
+ (nzExpandChange)="onExpandChange(subtask, $event)"
+ >
+ {{ subtask['subtask'] }}
+ <ng-container *ngIf="subtask['attempt-number'] !== undefined">
+ [attempt-{{ subtask['attempt-number'] + 1 }}]
Review Comment:
nit: I think it's better to use `padding` or `margin` instead of ` `, but it's a problem :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #20380:
URL: https://github.com/apache/flink/pull/20380#issuecomment-1201973124
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #20380:
URL: https://github.com/apache/flink/pull/20380#issuecomment-1202027949
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangjunhan commented on pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
yangjunhan commented on PR #20380:
URL: https://github.com/apache/flink/pull/20380#issuecomment-1200602489
@simplejason Thanks for the advice. All mentioned above have been taken care of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangjunhan commented on pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution
Posted by GitBox <gi...@apache.org>.
yangjunhan commented on PR #20380:
URL: https://github.com/apache/flink/pull/20380#issuecomment-1196525476
Hi, @simplejason. Could you help me review this PR which only concerns web UI changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org