[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5501: [TIR][REFACTOR] std::string -> String Migration in TIR nodes

[GitBox <gi...@apache.org>]

zhiics commented on a change in pull request #5501:
URL: https://github.com/apache/incubator-tvm/pull/5501#discussion_r422515023



##########
File path: src/target/llvm/codegen_llvm.cc
##########
@@ -685,11 +685,11 @@ llvm::Value* CodeGenLLVM::CreateCallExtern(const CallNode* op) {
   }
   llvm::FunctionType* ftype = llvm::FunctionType::get(
       GetLLVMType(GetRef<PrimExpr>(op)), arg_type, false);
-  llvm::Function* f = module_->getFunction(op->name);
+  llvm::Function* f = module_->getFunction((std::string)op->name);

Review comment:
       we should be able to use `op->name.c_str()` or `op->name.operator std::string()` instead of using this C-style explicit casting




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org