[GitHub] [apisix] Sn0rt commented on a diff in pull request #9436: docs: improve clickhouse logger docs

["Sn0rt (via GitHub)" <gi...@apache.org>]

Sn0rt commented on code in PR #9436:
URL: https://github.com/apache/apisix/pull/9436#discussion_r1197474401


##########
docs/en/latest/plugins/clickhouse-logger.md:
##########
@@ -81,25 +81,16 @@ curl http://127.0.0.1:9180/apisix/admin/plugin_metadata/clickhouse-logger -H 'X-
 }'
 ```
 
-You have to then create a table in your ClickHouse database to store the logs:
-
-```sql
-CREATE TABLE default.test (
-  `host` String,
-  `client_ip` String,
-  `route_id` String,
-  `service_id` String,
-  `@timestamp` String,
-   PRIMARY KEY(`@timestamp`)
-) ENGINE = MergeTree()
+You can use the clickhouse docker image to create a container like so:
+
+```shell
+docker run -d -p 8123:8123 -p 9000:9000 -p 9009:9009 --name some-clickhouse-server --ulimit nofile=262144:262144 clickhouse/clickhouse-server
 ```
 
-Now, if you run `select * from default.test;`, you will get the following row:
+Then create a table in your ClickHouse database to store the logs.
 
-```
-┌─host──────┬─client_ip─┬─route_id─┬─@timestamp────────────────┐
-│ 127.0.0.1 │ 127.0.0.1 │ 1        │ 2022-01-17T10:03:10+08:00 │
-└───────────┴───────────┴──────────┴───────────────────────────┘
+```shell

Review Comment:
   looks great. pls update Chinese doc too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org