You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/05/09 14:29:53 UTC

Review Request: CLOUDSTACK-2419 : Localization - Some Japanese are not working

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11021/
-----------------------------------------------------------

Review request for cloudstack, Fang Wang and Animesh Chaturvedi.


Description
-------

CLOUDSTACK-2419 : Localization - Some Japanese are not working

The following JP keys are not working:
• ~ ^
• [{
• ]}
• ' @
• ; +
• : *
• Numpad *
• Numpad +
• Numpad -
• Numpad /
• CAPS Lock
• Kanji Key 


This addresses bug CLOUDSTACK-2419.


Diffs
-----

  services/console-proxy/server/js/ajaxkeys.js 1ed41c5 

Diff: https://reviews.apache.org/r/11021/diff/


Testing
-------

Tested on my local CloudStack setup.


Thanks,

Sanjay Tripathi


Re: Review Request: CLOUDSTACK-2419 : Localization - Some Japanese are not working

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11021/#review20411
-----------------------------------------------------------


Commit fa9987753c530c8e9560297986ac8848b7526854 in branch refs/heads/master from Pranav Saxena <pr...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fa99877 ]

CLOUDSTACK-2419 : Localization - Some Japanese are not working


- ASF Subversion and Git Services


On May 9, 2013, 12:29 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11021/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 12:29 p.m.)
> 
> 
> Review request for cloudstack, Fang Wang and Animesh Chaturvedi.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2419 : Localization - Some Japanese are not working
> 
> The following JP keys are not working:
> • ~ ^
> • [{
> • ]}
> • ' @
> • ; +
> • : *
> • Numpad *
> • Numpad +
> • Numpad -
> • Numpad /
> • CAPS Lock
> • Kanji Key 
> 
> 
> This addresses bug CLOUDSTACK-2419.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 1ed41c5 
> 
> Diff: https://reviews.apache.org/r/11021/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request: CLOUDSTACK-2419 : Localization - Some Japanese are not working

Posted by Fang Wang <fa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11021/#review20386
-----------------------------------------------------------

Ship it!


ship it! looks good

- Fang Wang


On May 9, 2013, 12:29 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11021/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 12:29 p.m.)
> 
> 
> Review request for cloudstack, Fang Wang and Animesh Chaturvedi.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2419 : Localization - Some Japanese are not working
> 
> The following JP keys are not working:
> • ~ ^
> • [{
> • ]}
> • ' @
> • ; +
> • : *
> • Numpad *
> • Numpad +
> • Numpad -
> • Numpad /
> • CAPS Lock
> • Kanji Key 
> 
> 
> This addresses bug CLOUDSTACK-2419.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 1ed41c5 
> 
> Diff: https://reviews.apache.org/r/11021/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>