You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "mladjan-gadzic (via GitHub)" <gi...@apache.org> on 2023/08/24 17:27:29 UTC

[GitHub] [ozone] mladjan-gadzic opened a new pull request, #5219: HDDS-9206. testSnapshotBackgroundServices is failing most of the time in workflow run

mladjan-gadzic opened a new pull request, #5219:
URL: https://github.com/apache/ozone/pull/5219

   ## What changes were proposed in this pull request?
   Assertion that times out (compaction backup files pruning) during workflow run is commented out. This is only a temporary solution, because compaction backup files pruning is just a part of larger set of snapshot background services tests which are important. Jira <to_be_created> is created to fix this.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-9206
   
   ## How was this patch tested?
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] GeorgeJahad merged pull request #5219: HDDS-9206. testSnapshotBackgroundServices is failing most of the time in workflow run

Posted by "GeorgeJahad (via GitHub)" <gi...@apache.org>.
GeorgeJahad merged PR #5219:
URL: https://github.com/apache/ozone/pull/5219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] mladjan-gadzic commented on a diff in pull request #5219: HDDS-9206. testSnapshotBackgroundServices is failing most of the time in workflow run

Posted by "mladjan-gadzic (via GitHub)" <gi...@apache.org>.
mladjan-gadzic commented on code in PR #5219:
URL: https://github.com/apache/ozone/pull/5219#discussion_r1304668254


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java:
##########
@@ -1304,7 +1304,8 @@ public void testSnapshotBackgroundServices()
         compactionLogsDir, numberOfLogFiles, contentLength,
         currentCompactionLog);
 
-    checkIfCompactionBackupFilesWerePruned(sstBackupDir, numberOfSstFiles);
+    // TODO: create Jira to fix and re-enable this test

Review Comment:
   I added to PR description. Will add in code as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] mladjan-gadzic commented on pull request #5219: HDDS-9206. testSnapshotBackgroundServices is failing most of the time in workflow run

Posted by "mladjan-gadzic (via GitHub)" <gi...@apache.org>.
mladjan-gadzic commented on PR #5219:
URL: https://github.com/apache/ozone/pull/5219#issuecomment-1692157281

   Thank you @hemantk-12 for a quick response and review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] hemantk-12 commented on a diff in pull request #5219: HDDS-9206. testSnapshotBackgroundServices is failing most of the time in workflow run

Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on code in PR #5219:
URL: https://github.com/apache/ozone/pull/5219#discussion_r1304663820


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java:
##########
@@ -1304,7 +1304,8 @@ public void testSnapshotBackgroundServices()
         compactionLogsDir, numberOfLogFiles, contentLength,
         currentCompactionLog);
 
-    checkIfCompactionBackupFilesWerePruned(sstBackupDir, numberOfSstFiles);
+    // TODO: create Jira to fix and re-enable this test

Review Comment:
   Can you please create a jira and attach it here? Or use HDDS-9206? What ever you feel like?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org