You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Hao Hao <ha...@cloudera.com> on 2017/01/19 23:28:59 UTC
Review Request 55735: SENTRY-1596: Hive tests failing for
sentry-ha-redesign branch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55735/
-----------------------------------------------------------
Review request for sentry.
Repository: sentry
Description
-------
SENTRY-1596: Hive tests failing for sentry-ha-redesign branch
Change-Id: If4896f1594b214e4022d99fa0fcf2f18ec0f39d3
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 69fc8d2d1d2a6dd49c8f540b3439ce0732dd54fc
Diff: https://reviews.apache.org/r/55735/diff/
Testing
-------
Thanks,
Hao Hao
Re: Review Request 55735: SENTRY-1596: Hive tests failing for
sentry-ha-redesign branch
Posted by Hao Hao <ha...@cloudera.com>.
> On Jan. 20, 2017, 1:19 a.m., Alexander Kolbasov wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java, line 80
> > <https://reviews.apache.org/r/55735/diff/1/?file=1609900#file1609900line80>
> >
> > How would tests control whether enableNotificationLog is on or off?
There is a system property ENABLE_NOTIFICATION_LOG(sentry.e2etest.enable.notification.log) to enable it on or off for e2e tests.
- Hao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55735/#review162377
-----------------------------------------------------------
On Jan. 19, 2017, 11:28 p.m., Hao Hao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55735/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 11:28 p.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1596: Hive tests failing for sentry-ha-redesign branch
>
> Change-Id: If4896f1594b214e4022d99fa0fcf2f18ec0f39d3
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 69fc8d2d1d2a6dd49c8f540b3439ce0732dd54fc
>
> Diff: https://reviews.apache.org/r/55735/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hao Hao
>
>
Re: Review Request 55735: SENTRY-1596: Hive tests failing for
sentry-ha-redesign branch
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55735/#review162377
-----------------------------------------------------------
Fix it, then Ship it!
The fix is fine, but longer term we should resync this synchronization.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java (line 80)
<https://reviews.apache.org/r/55735/#comment233732>
How would tests control whether enableNotificationLog is on or off?
- Alexander Kolbasov
On Jan. 19, 2017, 11:28 p.m., Hao Hao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55735/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 11:28 p.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1596: Hive tests failing for sentry-ha-redesign branch
>
> Change-Id: If4896f1594b214e4022d99fa0fcf2f18ec0f39d3
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 69fc8d2d1d2a6dd49c8f540b3439ce0732dd54fc
>
> Diff: https://reviews.apache.org/r/55735/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hao Hao
>
>