You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/04/24 15:15:00 UTC

[jira] [Commented] (MSKINS-226) Add custom option to enable/disable AnchorJS along with options

    [ https://issues.apache.org/jira/browse/MSKINS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715870#comment-17715870 ] 

ASF GitHub Bot commented on MSKINS-226:
---------------------------------------

michael-o commented on PR #51:
URL: https://github.com/apache/maven-fluido-skin/pull/51#issuecomment-1520370123

   @hboutemy I will first apply the AnchorJS upgrade separately. As said, there is no way to explicitly disable this just like with other options and the inconsistency between AnchorJS IDs and Doxia IDs remains. I will leave this open for now. I still think that this is the right way since any other feature has to be enabled explicitly. This shouldn't be any different.




> Add custom option to enable/disable AnchorJS along with options
> ---------------------------------------------------------------
>
>                 Key: MSKINS-226
>                 URL: https://issues.apache.org/jira/browse/MSKINS-226
>             Project: Maven Skins
>          Issue Type: Improvement
>          Components: Fluido Skin
>    Affects Versions: fluido-2.0.0-M5
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: fluido-2.0.0-M6
>
>
> Not every one wants this to be enabled by default. An option should be added and the user needs to explicitly enable this, like with other JS-based options.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)