You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/05/08 05:20:53 UTC

[GitHub] [thrift] ctubbsii commented on a diff in pull request #2601: java lib to upgrade to gradle 7 and migrate from `maven` to `maven-publish` plugin

ctubbsii commented on code in PR #2601:
URL: https://github.com/apache/thrift/pull/2601#discussion_r867436633


##########
lib/java/Makefile.am:
##########
@@ -26,7 +26,7 @@ all-local:
 		--console=plain
 
 install-exec-hook:
-	$(GRADLE) $(GRADLE_OPTS) install \
+	$(GRADLE) $(GRADLE_OPTS) publishToMavenLocal \

Review Comment:
   Are the names `publishToMavenLocal` and `publish` defined in the plugin? Or are these defined somewhere in this build configuration?
   
   I ask only because it would be kind of nice to keep the same terminology as "maven" when performing maven operations. Maven calls publishing to the local repository "install", and publishing to an external repository "deploy". If we can use those names, that'd be great. If the plugin defines the names, then I guess our hands are tied.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org