You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/09 11:04:17 UTC

[GitHub] [arrow-datafusion] alamb commented on pull request #1077: [window function] add `percent_rank` window function

alamb commented on pull request #1077:
URL: https://github.com/apache/arrow-datafusion/pull/1077#issuecomment-939278053


   > @alamb in fact dense_rank function was already implemented, this PR only added percent rank and thus i needed to change the dense: bool to a three element enum. same goes to unit test, as the code originally covered both rank and dense_rank.
   
   I have (unbroken) the title of this PR now -- thank you for the clarification. Sorry for the mistake


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org