You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/01 11:29:26 UTC
[GitHub] [airflow] mik-laj opened a new pull request #17960: Delete unnecessary parameters in EKSPodOperator
mik-laj opened a new pull request #17960:
URL: https://github.com/apache/airflow/pull/17960
It deletes some parameters because they have no effect on the behavior of the operator/hook, because we generate a temporary file with credentials that always has only one cluster and one user.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #17960: Delete unnecessary parameters in EKSPodOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #17960:
URL: https://github.com/apache/airflow/pull/17960#issuecomment-911280876
> should we also add a test to assert the deprecation warnings?
This is not common in this project. We only have the warning tests in one place - when we moved the operators, to providers, but the goal there was not to prevent regression, but to track all changes so that we can prepare documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #17960: Delete unnecessary parameters in EKSPodOperator
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #17960:
URL: https://github.com/apache/airflow/pull/17960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17960: Delete unnecessary parameters in EKSPodOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17960:
URL: https://github.com/apache/airflow/pull/17960#issuecomment-911271140
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org