You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/31 20:40:42 UTC

[GitHub] [beam] KevinGG opened a new pull request #12740: [BEAM-10775] Added nodejs installation and documentation

KevinGG opened a new pull request #12740:
URL: https://github.com/apache/beam/pull/12740


   1. Added nodejs installation in scripts because Node.js is needed by jlpm.
   2. Added documentation of the typescript job to pull request template
      and README.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website | Whitespace
   --- | --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   ![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg)
   ![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...55b171a](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684030116


   Run Typescript PreCommit
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684026949


   Run Typescript PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684044675


   Run Typescript PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...c9f78c0](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684054371


   Run Typescript PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...63ce7fe](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684104758


   R: @pabloem 
   
   PTAL, thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684031306


   Run Typescript PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #12740: [BEAM-10775] Added nodejs installation and documented Typescript precommit job

Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #12740:
URL: https://github.com/apache/beam/pull/12740


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684104673


   Run Python PreCommit failed due to BEAM-10841.
   
   This PR does not contain Python code change and the `Typescript ("Run Typescript PreCommit")` has passed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684038263


   Run Typescript PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684060589


   Run Typescript PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684085411


   Run Typescript PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684037796


   Run Typescript PreCommit
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...55b171a](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on a change in pull request #12740: [BEAM-10775] Added nodejs installation and documented Typescript precommit job

Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #12740:
URL: https://github.com/apache/beam/pull/12740#discussion_r481307496



##########
File path: sdks/python/scripts/setup_nodejs.sh
##########
@@ -0,0 +1,33 @@
+#!/bin/bash
+#
+#    Licensed to the Apache Software Foundation (ASF) under one or more
+#    contributor license agreements.  See the NOTICE file distributed with
+#    this work for additional information regarding copyright ownership.
+#    The ASF licenses this file to You under the Apache License, Version 2.0
+#    (the "License"); you may not use this file except in compliance with
+#    the License.  You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS,
+#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#    See the License for the specific language governing permissions and
+#    limitations under the License.
+#
+#
+# The script installs nodejs and needs to be executed before run_eslint and
+# run_jest.
+
+set -e
+
+if ! command -v node; then
+  if command -v apt-get; then
+    # From https://github.com/nodesource/distributions.
+    curl -sL https://deb.nodesource.com/setup_lts.x | sudo -E bash -
+    sudo apt-get install -y nodejs

Review comment:
       Yes, we can run sudo on Jenkins workers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...63ce7fe](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...03742ac](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...a85d50f](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on a change in pull request #12740: [BEAM-10775] Added nodejs installation and documented Typescript precommit job

Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #12740:
URL: https://github.com/apache/beam/pull/12740#discussion_r481304098



##########
File path: sdks/python/scripts/setup_nodejs.sh
##########
@@ -0,0 +1,33 @@
+#!/bin/bash
+#
+#    Licensed to the Apache Software Foundation (ASF) under one or more
+#    contributor license agreements.  See the NOTICE file distributed with
+#    this work for additional information regarding copyright ownership.
+#    The ASF licenses this file to You under the Apache License, Version 2.0
+#    (the "License"); you may not use this file except in compliance with
+#    the License.  You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS,
+#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#    See the License for the specific language governing permissions and
+#    limitations under the License.
+#
+#
+# The script installs nodejs and needs to be executed before run_eslint and
+# run_jest.
+
+set -e
+
+if ! command -v node; then
+  if command -v apt-get; then
+    # From https://github.com/nodesource/distributions.
+    curl -sL https://deb.nodesource.com/setup_lts.x | sudo -E bash -
+    sudo apt-get install -y nodejs

Review comment:
       I am not ssure if we can run sudo on the jenkins workers? We can try and see what happens.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...55b171a](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...63ce7fe](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12740:
URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=h1) Report
   > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12740/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12740      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53670       +1     
   ==========================================
     Hits        21587    21587              
   - Misses      32082    32083       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12740/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=footer). Last update [aa345db...55b171a](https://codecov.io/gh/apache/beam/pull/12740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org