You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/23 06:27:37 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #12965: [FLINK-18552][tests] Update migration tests in master to cover migration till release-1.11
gaoyunhaii opened a new pull request #12965:
URL: https://github.com/apache/flink/pull/12965
**This PR picks the #12876 to release-1.11**
## What is the purpose of the change
This PR updates the following tests to cover migration till release-1.11 (including release-1.10 and release-1.11):
- `CEPMigrationTest`
- `BucketingSinkMigrationTest`
- `FlinkKafkaConsumerBaseMigrationTest`
- `ContinuousFileProcessingMigrationTest`
- `WindowOperatorMigrationTest`
- `StatefulJobSavepointMigrationITCase.scala`
- `StatefulJobWBroadcastStateMigrationITCase.scala`
## Brief change log
- c768117e95a5806c0caafcb567ddee9d6cd1ffa3 fixes for `CEPMigrationTest`
- aaf50401feaca88f7e992105369d025b07695937 fixes for `BucketingSinkMigrationTest`
- 7d2b7cf74574a50f098915fb34daa863fd97ee3c fixes for `FlinkKafkaConsumerBaseMigrationTest`
- a1f07bd541f551d55a627ea75efcd6106cb63c17 fixes for `ContinuousFileProcessingMigrationTest`
- 2be0da4cef2ddc556bcbbce5657abb375f672162 fixes for `WindowOperatorMigrationTest`
- 96e67ee5b0e8c1341bfe7354bdc50702a96f3c65 fixes for `StatefulJobSavepointMigrationITCase`
- f9457359a291e5df59f3448cda5f1816e7288c7f fixes for `StatefulJobWBroadcastStateMigrationITCase`
For each test, we
- Creates the corresponding savepoint/checkpoint files by running the corresponding `write*snapshots()` methods with the **corresponding branch**.
- Adds 1.10 and 1.11 versions to the migration test version list.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12965: [FLINK-18552][tests] Update migration tests in master to cover migration till release-1.11
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12965:
URL: https://github.com/apache/flink/pull/12965#issuecomment-662841389
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5366de911c86f37b837e8ebf2367d6d9ae5e5905 (Thu Jul 23 06:32:57 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12965: [FLINK-18552][tests] Update migration tests in master to cover migration till release-1.11
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12965:
URL: https://github.com/apache/flink/pull/12965#issuecomment-662850124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5366de911c86f37b837e8ebf2367d6d9ae5e5905",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4758",
"triggerID" : "5366de911c86f37b837e8ebf2367d6d9ae5e5905",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5366de911c86f37b837e8ebf2367d6d9ae5e5905 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4758)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12965: [FLINK-18552][tests] Update migration tests in master to cover migration till release-1.11
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12965:
URL: https://github.com/apache/flink/pull/12965#issuecomment-662850124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5366de911c86f37b837e8ebf2367d6d9ae5e5905",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5366de911c86f37b837e8ebf2367d6d9ae5e5905",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5366de911c86f37b837e8ebf2367d6d9ae5e5905 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12965: [FLINK-18552][tests] Update migration tests in master to cover migration till release-1.11
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12965:
URL: https://github.com/apache/flink/pull/12965#issuecomment-662850124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5366de911c86f37b837e8ebf2367d6d9ae5e5905",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4758",
"triggerID" : "5366de911c86f37b837e8ebf2367d6d9ae5e5905",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5366de911c86f37b837e8ebf2367d6d9ae5e5905 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4758)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #12965: [FLINK-18552][tests] Update migration tests in master to cover migration till release-1.11
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #12965:
URL: https://github.com/apache/flink/pull/12965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org