You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/14 00:45:23 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #20864: Add support for custom command and args in jobs
jedcunningham opened a new pull request #20864:
URL: https://github.com/apache/airflow/pull/20864
This allows custom command and args to be used for the database migration and create user jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#issuecomment-1020403769
This is one of the last places where we have differences between Airflow 1 and 2, and also don't support customization (which will allow us to more easily drop official support for 1).
This also provides more flexibility for future args in these jobs. For example, even now some installs could utilize `--use-random-password` when creating the initial user. There could be more in the future too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#issuecomment-1019374011
Hmmm. do we really want that ? I'd rather fix any issues resulting from running standard commands here, otherwise it's not different from just adding a hook to run any job at any moment, which is kinda strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r791081240
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
no objection from me. but may be better to just remove the `default` key entirely (though perhaps that's not allowed with our docs build process / pre-commit?)
i looked at the params page, and it is pretty tough to navigate. probably there is a better way to present this information. and if that is done, maybe then it's more worthwhile to add.
Along these lines, from code dupe perspective, perhaps defaults could be scraped from values.yaml for the purpose of docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r784430429
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
```suggestion
"default": "See values.yaml"
```
I almost did this, as this is a lot on the params page. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r791081240
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
no objection from me
separately, i looked at the params page, and it is pretty tough to navigate. probably there is a better way to present this information. and if that is done, maybe then it's more worthwhile to add.
Along these lines, from code dupe perspective, perhaps defaults could be scraped from values.yaml for the purpose of docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r791081240
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
no objection from me. but may be better to just remove the `default` key entirely (though perhaps that's not allowed with our docs build process / pre-commit?)
i looked at the params page, and it is pretty tough to navigate. probably there is a better way to present this information. and if that is done, maybe then it's more worthwhile to add.
Along these lines, from code dupe perspective, perhaps defaults could be scraped from values.yaml for the purpose of docs.
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
no objection from me
i looked at the params page, and it is pretty tough to navigate. probably there is a better way to present this information. and if that is done, maybe then it's more worthwhile to add.
Along these lines, from code dupe perspective, perhaps defaults could be scraped from values.yaml for the purpose of docs.
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
no objection from me
separately, i looked at the params page, and it is pretty tough to navigate. probably there is a better way to present this information. and if that is done, maybe then it's more worthwhile to add.
Along these lines, from code dupe perspective, perhaps defaults could be scraped from values.yaml for the purpose of docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r791086198
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
Yeah, our docs is "easy", but artifacthub uses the schema alone, e.g:
https://artifacthub.io/packages/helm/apache-airflow/airflow?modal=values-schema&path=workers.affinity
With fresh eyes, we probably should be removing "See values.yaml" instead of adding more.
And good callout on the params being rough... It does indeed need some tlc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#issuecomment-1047379642
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r791086198
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
Yeah, our docs is "easy", but artifacthub uses the schema alone, e.g:
https://artifacthub.io/packages/helm/apache-airflow/airflow?modal=values-schema&path=workers.affinity
With fresh eyes, we probably should be removing "See values.yaml" instead of adding more.
And good callout on the params being rough... It does indeed need some tlc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r784430429
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
```suggestion
"default": "See values.yaml",
```
I almost did this, as this is a lot on the params page. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#issuecomment-1020403769
This is one of the last places where we have differences between Airflow 1 and 2, and also don't support customization (which will allow us to more easily drop official support for 1).
This also provides more flexibility for future args in these jobs. For example, even now some installs could utilize `--use-random-password` when creating the initial user. There could be more in the future too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r791081240
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
no objection from me
i looked at the params page, and it is pretty tough to navigate. probably there is a better way to present this information. and if that is done, maybe then it's more worthwhile to add.
Along these lines, from code dupe perspective, perhaps defaults could be scraped from values.yaml for the purpose of docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #20864: Add support for custom command and args in jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #20864:
URL: https://github.com/apache/airflow/pull/20864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org